Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Unified Diff: chrome/browser/sync/profile_sync_service.h

Issue 1314903004: Sync: Refactoring DataTypeController to make the design shareable with USS datatypes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed CR comments Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/profile_sync_service.h
diff --git a/chrome/browser/sync/profile_sync_service.h b/chrome/browser/sync/profile_sync_service.h
index 3a24ff1313e17a021f8b26d384297ec2ffdb20e6..620f831dcfa9dc501071fb780d1e75191dc28b69 100644
--- a/chrome/browser/sync/profile_sync_service.h
+++ b/chrome/browser/sync/profile_sync_service.h
@@ -338,6 +338,8 @@ class ProfileSyncService : public sync_driver::SyncService,
// ProfileSyncService. It declares that this sync type may be activated at
// some point in the future. This function call does not enable or activate
// the syncing of this type
+ // TODO(stanisc): crbug.com/515962: this should merge with
+ // RegisterDataTypeController.
void RegisterNonBlockingType(syncer::ModelType type);
// Called by a component that supports non-blocking sync when it is ready to
@@ -347,6 +349,7 @@ class ProfileSyncService : public sync_driver::SyncService,
// should result in a message to enable syncing for this type when the sync
// backend is available. If the type is not to be synced, this should result
// in a message that allows the component to delete its local sync state.
+ // TODO(stanisc): crbug.com/515962: review usage of this.
void InitializeNonBlockingType(
syncer::ModelType type,
const scoped_refptr<base::SequencedTaskRunner>& task_runner,
« no previous file with comments | « chrome/browser/sync/profile_sync_components_factory_impl.h ('k') | chrome/browser/sync/profile_sync_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698