Sync: Refactoring DataTypeController to make the design shareable with USS datatypes.

components/sync_driver/proxy_data_type_controller.cc

Index: components/sync_driver/proxy_data_type_controller.cc
diff --git a/components/sync_driver/proxy_data_type_controller.cc b/components/sync_driver/proxy_data_type_controller.cc
index e9b87326ffa8afd9730f669b2708de1537a47b80..700fab6c6dfefdd980862c572ba28bf276efd0f1 100644
--- a/components/sync_driver/proxy_data_type_controller.cc
+++ b/components/sync_driver/proxy_data_type_controller.cc
@@ -4,6 +4,8 @@
 
 #include "components/sync_driver/proxy_data_type_controller.h"
 
+#include "sync/api/sync_merge_result.h"
+
 namespace sync_driver {
 
 ProxyDataTypeController::ProxyDataTypeController(
@@ -43,15 +45,6 @@ syncer::ModelType ProxyDataTypeController::type() const {
   return type_;
 }
 
-syncer::ModelSafeGroup ProxyDataTypeController::model_safe_group() const {
-  DCHECK(syncer::ProxyTypes().Has(type_));
-  return syncer::GROUP_PASSIVE;
-}
-
-ChangeProcessor* ProxyDataTypeController::GetChangeProcessor() const {
-  return NULL;
-}
-
 std::string ProxyDataTypeController::name() const {
   // For logging only.
   return syncer::ModelTypeToString(type());
@@ -70,4 +63,10 @@ void ProxyDataTypeController::OnModelLoaded() {
   NOTIMPLEMENTED();
 }
 
+void ProxyDataTypeController::ActivateDataType(
+    BackendDataTypeConfigurer* configurer) {}

[Nicolas Zea, 2015/09/02 22:52:45]

Neat! Glad that this abstractions gives us the ability to better control
datatypes that can't be activated/deactivated.

[stanisc, 2015/09/03 01:17:43]

Acknowledged.

+
+void ProxyDataTypeController::DeactivateDataType(
+    BackendDataTypeConfigurer* configurer) {}
+
 }  // namespace sync_driver