Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(579)

Unified Diff: components/password_manager/core/browser/affiliated_match_helper_unittest.cc

Issue 1314903003: Updating of all entries in PasswordManager of the same credentials on password update (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: bot fix Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/affiliated_match_helper_unittest.cc
diff --git a/components/password_manager/core/browser/affiliated_match_helper_unittest.cc b/components/password_manager/core/browser/affiliated_match_helper_unittest.cc
index df14a14bfcdd00b0ed505b9bede8bb95985e743f..633924f50bfef4a9005876447593f30c99c35358 100644
--- a/components/password_manager/core/browser/affiliated_match_helper_unittest.cc
+++ b/components/password_manager/core/browser/affiliated_match_helper_unittest.cc
@@ -99,7 +99,6 @@ const char kTestAndroidFacetURIBeta2[] =
const char kTestAndroidFacetURIBeta3[] =
"android://hash@com.yetanother.beta.android";
const char kTestWebRealmBeta1[] = "https://one.beta.example.com/";
-const char kTestWebOriginBeta1[] = "https://one.beta.example.com/login";
const char kTestAndroidRealmBeta2[] =
"android://hash@com.example.beta.android/";
const char kTestAndroidRealmBeta3[] =
@@ -564,44 +563,4 @@ TEST_F(AffiliatedMatchHelperTest, DestroyBeforeDeferredInitialization) {
ASSERT_NO_FATAL_FAILURE(RunDeferredInitialization());
}
-TEST_F(AffiliatedMatchHelperTest, TransformAffiliatedAndroidCredentials) {
- const char kTestUsername2[] = "JohnDoe2";
- const char kTestPassword2[] = "secret2";
-
- autofill::PasswordForm observed_form(
- GetTestObservedWebForm(kTestWebRealmBeta1, kTestWebOriginBeta1));
-
- ScopedVector<autofill::PasswordForm> matched_forms;
- matched_forms.push_back(make_scoped_ptr(new autofill::PasswordForm(
- GetTestAndroidCredentials(kTestAndroidRealmBeta2))));
- matched_forms.push_back(make_scoped_ptr(new autofill::PasswordForm(
- GetTestAndroidCredentials(kTestAndroidRealmBeta3))));
- matched_forms[1]->username_value = base::ASCIIToUTF16(kTestUsername2);
- matched_forms[1]->password_value = base::ASCIIToUTF16(kTestPassword2);
-
- ScopedVector<autofill::PasswordForm> transformed_forms =
- AffiliatedMatchHelper::TransformAffiliatedAndroidCredentials(
- observed_form, matched_forms.Pass());
-
- ASSERT_EQ(2u, transformed_forms.size());
-
- EXPECT_EQ(base::ASCIIToUTF16(kTestUsername),
- transformed_forms[0]->username_value);
- EXPECT_EQ(base::ASCIIToUTF16(kTestPassword),
- transformed_forms[0]->password_value);
- EXPECT_EQ(GURL(kTestWebOriginBeta1), transformed_forms[0]->origin);
- EXPECT_EQ(kTestWebRealmBeta1, transformed_forms[0]->signon_realm);
- EXPECT_EQ(kTestAndroidRealmBeta2,
- transformed_forms[0]->original_signon_realm);
-
- EXPECT_EQ(base::ASCIIToUTF16(kTestUsername2),
- transformed_forms[1]->username_value);
- EXPECT_EQ(base::ASCIIToUTF16(kTestPassword2),
- transformed_forms[1]->password_value);
- EXPECT_EQ(GURL(kTestWebOriginBeta1), transformed_forms[1]->origin);
- EXPECT_EQ(kTestWebRealmBeta1, transformed_forms[1]->signon_realm);
- EXPECT_EQ(kTestAndroidRealmBeta3,
- transformed_forms[1]->original_signon_realm);
-}
-
} // namespace password_manager

Powered by Google App Engine
This is Rietveld 408576698