chrome/browser/ui/passwords/manage_passwords_state.cc - Issue 1314903003: Updating of all entries in PasswordManager of the same credentials on password update

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/passwords/manage_passwords_state.cc

Issue 1314903003: Updating of all entries in PasswordManager of the same credentials on password update (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: bot fix Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/password_manager/password_store_mac_unittest.cc ('k') | chrome/browser/ui/passwords/manage_passwords_state_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/passwords/manage_passwords_state.cc

diff --git a/chrome/browser/ui/passwords/manage_passwords_state.cc b/chrome/browser/ui/passwords/manage_passwords_state.cc

index dda3d3ade7fd5b68dfb15202c60716813a3fc9a3..33649b86676a31a67d73d5466eb43c0e97c09939 100644

--- a/chrome/browser/ui/passwords/manage_passwords_state.cc

+++ b/chrome/browser/ui/passwords/manage_passwords_state.cc

@@ -149,7 +149,7 @@ void ManagePasswordsState::OnPasswordAutofilled(

// TODO(vabr): Revert back to DCHECK once http://crbug.com/486931 is fixed.

CHECK(!password_form_map.empty());

ClearData();

- if (password_form_map.begin()->second->IsPublicSuffixMatch()) {

+ if (password_form_map.begin()->second->is_public_suffix_match) {

// Don't show the UI for PSL matched passwords. They are not stored for this

// page and cannot be deleted.

origin_ = GURL();