Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(556)

Unified Diff: components/autofill/core/common/password_form_fill_data.cc

Issue 1314903003: Updating of all entries in PasswordManager of the same credentials on password update (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed Vasilii comments Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/common/password_form_fill_data.cc
diff --git a/components/autofill/core/common/password_form_fill_data.cc b/components/autofill/core/common/password_form_fill_data.cc
index 702d279fcf80c4d8f41c630abc96083b9ffeebdf..e56b1c4d9cb90f856fdc229540c3b8c0844ceec3 100644
--- a/components/autofill/core/common/password_form_fill_data.cc
+++ b/components/autofill/core/common/password_form_fill_data.cc
@@ -58,7 +58,8 @@ void InitPasswordFormFillData(
result->is_possible_change_password_form =
form_on_page.IsPossibleChangePasswordForm();
- result->preferred_realm = preferred_match->original_signon_realm;
+ if (preferred_match->is_public_suffix_match)
+ result->preferred_realm = preferred_match->signon_realm;
// Copy additional username/value pairs.
PasswordFormMap::const_iterator iter;
@@ -66,7 +67,8 @@ void InitPasswordFormFillData(
if (iter->second != preferred_match) {
PasswordAndRealm value;
value.password = iter->second->password_value;
- value.realm = iter->second->original_signon_realm;
+ if (iter->second->is_public_suffix_match)
+ value.realm = iter->second->signon_realm;
result->additional_logins[iter->first] = value;
}
if (enable_other_possible_usernames &&
@@ -78,7 +80,8 @@ void InitPasswordFormFillData(
UsernamesCollectionKey key;
key.username = iter->first;
key.password = iter->second->password_value;
- key.realm = iter->second->original_signon_realm;
+ if (iter->second->is_public_suffix_match)
+ key.realm = iter->second->signon_realm;
result->other_possible_usernames[key] =
iter->second->other_possible_usernames;
}

Powered by Google App Engine
This is Rietveld 408576698