Updating of all entries in PasswordManager of the same credentials on password update

components/password_manager/core/browser/login_database.cc

Index: components/password_manager/core/browser/login_database.cc
diff --git a/components/password_manager/core/browser/login_database.cc b/components/password_manager/core/browser/login_database.cc
index 62194a5482c57a70b9e023460e77db7041bdaf7e..0edb4c95f75fcdde3741bbf9e6d5554c91c96b87 100644
--- a/components/password_manager/core/browser/login_database.cc
+++ b/components/password_manager/core/browser/login_database.cc
@@ -936,7 +936,7 @@ PasswordStoreChangeList LoginDatabase::UpdateLogin(const PasswordForm& form) {
 }
 
 bool LoginDatabase::RemoveLogin(const PasswordForm& form) {
-  if (form.IsPublicSuffixMatch()) {
+  if (form.is_public_suffix_match) {

[vasilii, 2015/09/25 14:16:15]

Hmm, I think the comment isn't true anymore. The PSL match should be in the
database and, therefore, can be deleted.

[dvadym, 2015/09/28 13:58:40]

I agree that the comment is not true. But that the question should we allow to
delete it. I've changed comment to
"TODO(dvadym): Discuss whether we should allow to remove PSL matched
credentials."
 and I'll ask this question on team meeting.

[vasilii, 2015/09/29 10:37:34]

I think the PSL matches aren't displayed in the password bubble.
- if there are non-PSL matches than they have a higher score and hide a PSL one.
- otherwise, they aren't shown in the bubble.

The Credential Manager API doesn't use PSL. So removing the line seems OK. You
can do it later.

     // Do not try to remove |form|. It is a modified copy of a password stored
     // for a different origin, and it is not contained in the database.
     return false;
@@ -1227,16 +1227,7 @@ bool LoginDatabase::StatementToForms(
       }
 
       psl_domain_match_metric = PSL_DOMAIN_MATCH_FOUND;
-      // This is not a perfect match, so we need to create a new valid result.
-      // We do this by copying over origin, signon realm and action from the
-      // observed form and setting the original signon realm to what we found
-      // in the database. We use the fact that |original_signon_realm| is
-      // non-empty to communicate that this match was found using public
-      // suffix matching.
-      new_form->original_signon_realm = new_form->signon_realm;
-      new_form->origin = psl_match->origin;
-      new_form->signon_realm = psl_match->signon_realm;
-      new_form->action = psl_match->action;
+      new_form->is_public_suffix_match = true;
     }
     forms->push_back(new_form.Pass());
   }