components/autofill/core/common/save_password_progress_logger.cc - Issue 1314903003: Updating of all entries in PasswordManager of the same credentials on password update

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/common/save_password_progress_logger.cc

Issue 1314903003: Updating of all entries in PasswordManager of the same credentials on password update (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Removed strings from progress loader Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/autofill/core/common/password_form_fill_data_unittest.cc ('K') | « components/autofill/core/common/save_password_progress_logger.h ('k') | components/password_manager/core/browser/affiliated_match_helper.h » ('j') | components/password_manager/core/browser/affiliated_match_helper.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/common/save_password_progress_logger.cc

diff --git a/components/autofill/core/common/save_password_progress_logger.cc b/components/autofill/core/common/save_password_progress_logger.cc

index c7c51ccceb56cfed3cfa274b271db37b07d9b084..328844792aae205667e2f4c6f35272d6a772c950 100644

--- a/components/autofill/core/common/save_password_progress_logger.cc

+++ b/components/autofill/core/common/save_password_progress_logger.cc

@@ -80,8 +80,6 @@ void SavePasswordProgressLogger::LogPasswordForm(

GetStringFromID(FormSchemeToStringID(form.scheme)));

log.SetString(GetStringFromID(STRING_SIGNON_REALM),

ScrubURL(GURL(form.signon_realm)));

- log.SetString(GetStringFromID(STRING_ORIGINAL_SIGNON_REALM),

- ScrubURL(GURL(form.original_signon_realm)));

log.SetString(GetStringFromID(STRING_ORIGIN), ScrubURL(form.origin));

log.SetString(GetStringFromID(STRING_ACTION), ScrubURL(form.action));

log.SetString(GetStringFromID(STRING_USERNAME_ELEMENT),

@@ -184,8 +182,6 @@ std::string SavePasswordProgressLogger::GetStringFromID(

return "Scheme";

case SavePasswordProgressLogger::STRING_SIGNON_REALM:

return "Signon realm";

- case SavePasswordProgressLogger::STRING_ORIGINAL_SIGNON_REALM:

vabr (Chromium) 2015/09/24 15:17:33 Could you please add logging of the |is_public_suf

dvadym 2015/09/25 10:19:52 Done.

- return "Original signon realm";

case SavePasswordProgressLogger::STRING_ORIGIN:

return "Origin";

case SavePasswordProgressLogger::STRING_ACTION: