Updating of all entries in PasswordManager of the same credentials on password update

components/password_manager/core/browser/login_database.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/password_manager/core/browser/login_database.h"
 
 #include <algorithm>
 #include <limits>
 
 #include "base/bind.h"
@@ skipping 918 matching lines @@
     return PasswordStoreChangeList();
 
   PasswordStoreChangeList list;
   if (db_.GetLastChangeCount())
     list.push_back(PasswordStoreChange(PasswordStoreChange::UPDATE, form));
 
   return list;
 }
 
 bool LoginDatabase::RemoveLogin(const PasswordForm& form) {
-  if (form.IsPublicSuffixMatch()) {
-    // Do not try to remove |form|. It is a modified copy of a password stored
-    // for a different origin, and it is not contained in the database.
+  if (form.is_public_suffix_match) {
+    // TODO(dvadym): Discuss whether we should allow to remove PSL matched
+    // credentials.
     return false;
   }
   // Remove a login by UNIQUE-constrained fields.
   sql::Statement s(db_.GetCachedStatement(SQL_FROM_HERE,
                                           "DELETE FROM logins WHERE "
                                           "origin_url = ? AND "
                                           "username_element = ? AND "
                                           "username_value = ? AND "
                                           "password_element = ? AND "
                                           "submit_element = ? AND "
@@ skipping 268 matching lines @@
     if (psl_match && psl_match->signon_realm != new_form->signon_realm) {
       if (new_form->scheme != PasswordForm::SCHEME_HTML)
         continue;  // Ignore non-HTML matches.
 
       if (!IsPublicSuffixDomainMatch(new_form->signon_realm,
                                      psl_match->signon_realm)) {
         continue;
       }
 
       psl_domain_match_metric = PSL_DOMAIN_MATCH_FOUND;
-      // This is not a perfect match, so we need to create a new valid result.
-      // We do this by copying over origin, signon realm and action from the
-      // observed form and setting the original signon realm to what we found
-      // in the database. We use the fact that |original_signon_realm| is
-      // non-empty to communicate that this match was found using public
-      // suffix matching.
-      new_form->original_signon_realm = new_form->signon_realm;
-      new_form->origin = psl_match->origin;
-      new_form->signon_realm = psl_match->signon_realm;
-      new_form->action = psl_match->action;
+      new_form->is_public_suffix_match = true;
     }
     forms->push_back(new_form.Pass());
   }
 
   if (psl_match) {
     UMA_HISTOGRAM_ENUMERATION("PasswordManager.PslDomainMatchTriggering",
                               psl_domain_match_metric, PSL_DOMAIN_MATCH_COUNT);
   }
 
   if (!statement->Succeeded())
     return false;
   return true;
 }
 
 }  // namespace password_manager