Updating of all entries in PasswordManager of the same credentials on password update

chrome/browser/password_manager/native_backend_libsecret_unittest.cc

 // Copyright (c) 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stdarg.h>
 
 #include "base/basictypes.h"
 #include "base/location.h"
 #include "base/prefs/pref_service.h"
 #include "base/single_thread_task_runner.h"
@@ skipping 446 matching lines @@
     PasswordForm m_facebook_lookup;
     m_facebook_lookup.origin = kMobileURL;
     m_facebook_lookup.signon_realm = kMobileURL.spec();
     ScopedVector<autofill::PasswordForm> form_list;
     EXPECT_TRUE(backend.GetLogins(m_facebook_lookup, &form_list));
 
     EXPECT_EQ(1u, global_mock_libsecret_items->size());
     EXPECT_EQ(1u, form_list.size());
     PasswordForm m_facebook = *form_list[0];
     form_list.clear();
-    EXPECT_EQ(kMobileURL, m_facebook.origin);
-    EXPECT_EQ(kMobileURL.spec(), m_facebook.signon_realm);
+    m_facebook.origin = kMobileURL;
+    m_facebook.signon_realm = kMobileURL.spec();
 
     // Add the PSL-matched copy to saved logins.
     VerifiedAdd(&backend, m_facebook);
     EXPECT_EQ(2u, global_mock_libsecret_items->size());
 
     // Update www.facebook.com login.
     PasswordForm new_facebook(form_facebook_);
     const base::string16 kOldPassword(form_facebook_.password_value);
     const base::string16 kNewPassword(UTF8ToUTF16("new_b"));
     EXPECT_NE(kOldPassword, kNewPassword);
     new_facebook.password_value = kNewPassword;
     switch (update_type) {
       case UPDATE_BY_UPDATELOGIN:
         VerifiedUpdate(&backend, new_facebook);
         break;
       case UPDATE_BY_ADDLOGIN:
         // This is an overwrite call.
         backend.AddLogin(new_facebook);
         break;
     }
 
     EXPECT_EQ(2u, global_mock_libsecret_items->size());
 
     // Check that m.facebook.com login was not modified by the update.
     EXPECT_TRUE(backend.GetLogins(m_facebook_lookup, &form_list));
 
     // There should be two results -- the exact one, and the PSL-matched one.
     EXPECT_EQ(2u, form_list.size());
     size_t index_non_psl = 0;
-    if (!form_list[index_non_psl]->original_signon_realm.empty())
+    if (form_list[index_non_psl]->IsPublicSuffixMatch())
       index_non_psl = 1;
     EXPECT_EQ(kMobileURL, form_list[index_non_psl]->origin);
     EXPECT_EQ(kMobileURL.spec(), form_list[index_non_psl]->signon_realm);
     EXPECT_EQ(kOldPassword, form_list[index_non_psl]->password_value);
     form_list.clear();
 
     // Check that www.facebook.com login was modified by the update.
     EXPECT_TRUE(backend.GetLogins(form_facebook_, &form_list));
     // There should be two results -- the exact one, and the PSL-matched one.
     EXPECT_EQ(2u, form_list.size());
     index_non_psl = 0;
-    if (!form_list[index_non_psl]->original_signon_realm.empty())
+    if (form_list[index_non_psl]->IsPublicSuffixMatch())
       index_non_psl = 1;
     EXPECT_EQ(form_facebook_.origin, form_list[index_non_psl]->origin);
     EXPECT_EQ(form_facebook_.signon_realm,
               form_list[index_non_psl]->signon_realm);
     EXPECT_EQ(kNewPassword, form_list[index_non_psl]->password_value);
     form_list.clear();
   }
 
   // Checks various types of matching for forms with a non-HTML |scheme|.
   void CheckMatchingWithScheme(const PasswordForm::Scheme& scheme) {
@@ skipping 104 matching lines @@
     CheckMockSecretItem((*global_mock_libsecret_items)[0], form_google_,
                         "chrome-42");
 }
 
 // Save a password for www.facebook.com and see it suggested for m.facebook.com.
 TEST_F(NativeBackendLibsecretTest, PSLMatchingPositive) {
   PasswordForm result;
   const GURL kMobileURL("http://m.facebook.com/");
   EXPECT_TRUE(CheckCredentialAvailability(form_facebook_, kMobileURL,
                                           PasswordForm::SCHEME_HTML, &result));
-  EXPECT_EQ(kMobileURL, result.origin);
-  EXPECT_EQ(kMobileURL.spec(), result.signon_realm);
+  EXPECT_EQ(form_facebook_.origin, result.origin);
+  EXPECT_EQ(form_facebook_.signon_realm, result.signon_realm);
 }
 
 // Save a password for www.facebook.com and see it not suggested for
 // m-facebook.com.
 TEST_F(NativeBackendLibsecretTest, PSLMatchingNegativeDomainMismatch) {
   EXPECT_FALSE(CheckCredentialAvailability(form_facebook_,
                                            GURL("http://m-facebook.com/"),
                                            PasswordForm::SCHEME_HTML, nullptr));
 }
 
@@ skipping 258 matching lines @@
   EXPECT_EQ(form_google_, *form_list[0]);
 
   EXPECT_EQ(1u, global_mock_libsecret_items->size());
   if (!global_mock_libsecret_items->empty()) {
     CheckMockSecretItem((*global_mock_libsecret_items)[0], form_google_,
                         "chrome-42");
   }
 }
 
 // TODO(mdm): add more basic tests here at some point.