Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(586)

Issue 1314893002: Update a test to use PushSubscription.getKey() (Closed)

Created:
5 years, 4 months ago by Peter Beverloo
Modified:
5 years, 3 months ago
CC:
chromium-reviews, mvanouwerkerk+watch_chromium.org, peter+watch_chromium.org, johnme+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update a test to use PushSubscription.getKey() The PushSubscription.curve25519dh property is now exposed through a getKey() method that takes the curve type as the first and only argument. Update the test to use this instead. This CL is part of a three-sided patch: [1] https://codereview.chromium.org/1309723004/ [2] This CL. [3] https://codereview.chromium.org/1316693002/ BUG=486040 Committed: https://crrev.com/908a130993076bf98bb5db216bdec2a1919da88b Cr-Commit-Position: refs/heads/master@{#345863}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/test/data/push_messaging/push_test.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (6 generated)
Peter Beverloo
PTAL
5 years, 4 months ago (2015-08-25 13:19:58 UTC) #2
Michael van Ouwerkerk
lgtm
5 years, 4 months ago (2015-08-25 16:18:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1314893002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1314893002/1
5 years, 3 months ago (2015-08-26 14:45:03 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_rel/builds/126332)
5 years, 3 months ago (2015-08-26 15:02:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1314893002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1314893002/1
5 years, 3 months ago (2015-08-26 17:41:33 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/104780)
5 years, 3 months ago (2015-08-26 17:54:13 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1314893002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1314893002/1
5 years, 3 months ago (2015-08-27 11:35:21 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-08-27 13:32:21 UTC) #14
commit-bot: I haz the power
5 years, 3 months ago (2015-08-27 13:33:34 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/908a130993076bf98bb5db216bdec2a1919da88b
Cr-Commit-Position: refs/heads/master@{#345863}

Powered by Google App Engine
This is Rietveld 408576698