Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Unified Diff: runtime/vm/stub_code_arm64.cc

Issue 1314883002: VM: Use constant pool also for leaf runtime calls on x64, arm, arm64 and mips. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: use StubEntry::label directly Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/stub_code_arm.cc ('k') | runtime/vm/stub_code_mips.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/stub_code_arm64.cc
diff --git a/runtime/vm/stub_code_arm64.cc b/runtime/vm/stub_code_arm64.cc
index 9f050e67cd13f73c905596643d499189b2770348..e928011e953d6f99fc24269ae56e5d4085f5c5a0 100644
--- a/runtime/vm/stub_code_arm64.cc
+++ b/runtime/vm/stub_code_arm64.cc
@@ -448,8 +448,7 @@ static void GenerateDeoptimizationSequence(Assembler* assembler,
bool preserve_result) {
// DeoptimizeCopyFrame expects a Dart frame, i.e. EnterDartFrame(0), but there
// is no need to set the correct PC marker or load PP, since they get patched.
- __ EnterFrame(0);
- __ TagAndPushPPAndPcMarker(ZR);
+ __ EnterStubFrame();
// The code in this frame may not cause GC. kDeoptimizeCopyFrameRuntimeEntry
// and kDeoptimizeFillFrameRuntimeEntry are leaf runtime calls.
@@ -480,13 +479,12 @@ static void GenerateDeoptimizationSequence(Assembler* assembler,
}
// There is a Dart Frame on the stack. We must restore PP and leave frame.
- __ LeaveDartFrame();
+ __ LeaveStubFrame();
__ sub(SP, FP, Operand(R0));
// DeoptimizeFillFrame expects a Dart frame, i.e. EnterDartFrame(0), but there
// is no need to set the correct PC marker or load PP, since they get patched.
- __ EnterFrame(0);
- __ TagAndPushPPAndPcMarker(ZR);
+ __ EnterStubFrame();
if (preserve_result) {
__ Push(R1); // Preserve result as first local.
@@ -500,7 +498,7 @@ static void GenerateDeoptimizationSequence(Assembler* assembler,
}
// Code above cannot cause GC.
// There is a Dart Frame on the stack. We must restore PP and leave frame.
- __ LeaveDartFrame();
+ __ LeaveStubFrame();
// Frame is fully rewritten at this point and it is safe to perform a GC.
// Materialize any objects that were deferred by FillFrame because they
« no previous file with comments | « runtime/vm/stub_code_arm.cc ('k') | runtime/vm/stub_code_mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698