runtime/vm/runtime_entry_x64.cc - Issue 1314883002: VM: Use constant pool also for leaf runtime calls on x64, arm, arm64 and mips.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/runtime_entry_x64.cc

Issue 1314883002: VM: Use constant pool also for leaf runtime calls on x64, arm, arm64 and mips. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: use StubEntry::label directly Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/runtime_entry_x64.cc

diff --git a/runtime/vm/runtime_entry_x64.cc b/runtime/vm/runtime_entry_x64.cc

index df24e7065d9f525d55463b7dd65ab8d6e0305505..a6ff6359720afc29de6328385d3c5950eeb2e76a 100644

--- a/runtime/vm/runtime_entry_x64.cc

+++ b/runtime/vm/runtime_entry_x64.cc

@@ -24,7 +24,9 @@ void RuntimeEntry::Call(Assembler* assembler, intptr_t argument_count) const {

if (is_leaf()) {

ASSERT(argument_count == this->argument_count());

ExternalLabel label(GetEntryPoint());

- __ CallCFunction(&label);

+ COMPILE_ASSERT(CallingConventions::kVolatileCpuRegisters & (1 << RAX));

+ __ LoadExternalLabel(RAX, &label, kNotPatchable);

+ __ CallCFunction(RAX);

} else {

// Argument count is not checked here, but in the runtime entry for a more

// informative error message.

« no previous file with comments | « runtime/vm/runtime_entry_mips.cc ('k') | runtime/vm/stub_code_arm.cc » ('j') | no next file with comments »