Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Unified Diff: runtime/vm/assembler_x64.h

Issue 1314883002: VM: Use constant pool also for leaf runtime calls on x64, arm, arm64 and mips. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: use StubEntry::label directly Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/assembler_mips.cc ('k') | runtime/vm/assembler_x64.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/assembler_x64.h
diff --git a/runtime/vm/assembler_x64.h b/runtime/vm/assembler_x64.h
index 3dab1ccd84a886f39891f875c4235e7dbf3e69bf..5cb3c177044d977de426fa2bc85c2682cdefb770 100644
--- a/runtime/vm/assembler_x64.h
+++ b/runtime/vm/assembler_x64.h
@@ -686,7 +686,6 @@ class Assembler : public ValueObject {
// Note: verified_mem mode forces far jumps.
void j(Condition condition, Label* label, bool near = kFarJump);
- void j(Condition condition, const ExternalLabel* label);
void jmp(Register reg);
void jmp(const Address& address);
@@ -767,15 +766,10 @@ class Assembler : public ValueObject {
void LoadFunctionFromCalleePool(Register dst,
const Function& function,
Register new_pp);
- void JmpPatchable(const ExternalLabel* label, Register pp);
void JmpPatchable(const StubEntry& stub_entry, Register pp);
- void Jmp(const ExternalLabel* label, Register pp);
void Jmp(const StubEntry& stub_entry, Register pp);
- void J(Condition condition, const ExternalLabel* label, Register pp);
void J(Condition condition, const StubEntry& stub_entry, Register pp);
- void CallPatchable(const ExternalLabel* label);
void CallPatchable(const StubEntry& stub_entry);
- void Call(const ExternalLabel* label);
void Call(const StubEntry& stub_entry);
// Unaware of write barrier (use StoreInto* methods for storing to objects).
// TODO(koda): Add StackAddress/HeapAddress types to prevent misuse.
@@ -849,7 +843,6 @@ class Assembler : public ValueObject {
// Call runtime function. Reserves shadow space on the stack before calling
// if platform ABI requires that. Does not restore RSP after the call itself.
- void CallCFunction(const ExternalLabel* label);
void CallCFunction(Register reg);
/*
« no previous file with comments | « runtime/vm/assembler_mips.cc ('k') | runtime/vm/assembler_x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698