Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Unified Diff: runtime/vm/assembler_arm64.h

Issue 1314883002: VM: Use constant pool also for leaf runtime calls on x64, arm, arm64 and mips. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: use StubEntry::label directly Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/assembler_arm.cc ('k') | runtime/vm/assembler_arm64.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/assembler_arm64.h
diff --git a/runtime/vm/assembler_arm64.h b/runtime/vm/assembler_arm64.h
index dce047fca0503f703634c177b78af57cffa556a1..dbb4a3b5fff371d1acfec0355507be935859a97c 100644
--- a/runtime/vm/assembler_arm64.h
+++ b/runtime/vm/assembler_arm64.h
@@ -1198,37 +1198,14 @@ class Assembler : public ValueObject {
LslImmediate(dst, src, kSmiTagSize);
}
- // Branching to ExternalLabels.
- void Branch(const ExternalLabel* label) {
- LoadExternalLabel(TMP, label);
- br(TMP);
- }
-
void Branch(const StubEntry& stub_entry);
-
- // Fixed length branch to label.
- void BranchPatchable(const ExternalLabel* label) {
- // TODO(zra): Use LoadExternalLabelFixed if possible.
- LoadImmediateFixed(TMP, label->address());
- br(TMP);
- }
-
void BranchPatchable(const StubEntry& stub_entry);
- void BranchLink(const ExternalLabel* label) {
- LoadExternalLabel(TMP, label);
- blr(TMP);
- }
-
+ void BranchLink(const ExternalLabel* label);
void BranchLink(const StubEntry& stub_entry);
// BranchLinkPatchable must be a fixed-length sequence so we can patch it
// with the debugger.
- void BranchLinkPatchable(const ExternalLabel* label) {
- LoadExternalLabelFixed(TMP, label, kPatchable);
- blr(TMP);
- }
-
void BranchLinkPatchable(const StubEntry& stub_entry);
// Macros accepting a pp Register argument may attempt to load values from
@@ -1448,6 +1425,10 @@ class Assembler : public ValueObject {
bool constant_pool_allowed_;
+ void Branch(const ExternalLabel* label);
+ void BranchPatchable(const ExternalLabel* label);
+ void BranchLinkPatchable(const ExternalLabel* label);
+
void LoadObjectHelper(Register dst, const Object& obj, bool is_unique);
void AddSubHelper(OperandSize os, bool set_flags, bool subtract,
« no previous file with comments | « runtime/vm/assembler_arm.cc ('k') | runtime/vm/assembler_arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698