Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Unified Diff: runtime/vm/assembler_arm.h

Issue 1314883002: VM: Use constant pool also for leaf runtime calls on x64, arm, arm64 and mips. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: use StubEntry::label directly Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/assembler_arm.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/assembler_arm.h
diff --git a/runtime/vm/assembler_arm.h b/runtime/vm/assembler_arm.h
index 8218bb9faa85971e0412ebf7395d334c5a4529c8..79dbea8b317ceb52fdb97ff9f4474bb3d36895dc 100644
--- a/runtime/vm/assembler_arm.h
+++ b/runtime/vm/assembler_arm.h
@@ -608,22 +608,16 @@ class Assembler : public ValueObject {
// Macros.
// Branch to an entry address. Call sequence is never patched.
- void Branch(const ExternalLabel* label, Condition cond = AL);
void Branch(const StubEntry& stub_entry, Condition cond = AL);
// Branch to an entry address. Call sequence can be patched or even replaced.
- void BranchPatchable(const ExternalLabel* label);
void BranchPatchable(const StubEntry& stub_entry);
- // Branch and link to an entry address. Call sequence is never patched.
- void BranchLink(const ExternalLabel* label);
- void BranchLink(const StubEntry& stub_entry);
-
+ void BranchLink(const StubEntry& stub_entry,
+ Patchability patchable = kNotPatchable);
void BranchLink(const ExternalLabel* label, Patchability patchable);
- void BranchLink(const StubEntry& stub_entry, Patchability patchable);
// Branch and link to an entry address. Call sequence can be patched.
- void BranchLinkPatchable(const ExternalLabel* label);
void BranchLinkPatchable(const StubEntry& stub_entry);
// Branch and link to [base + offset]. Call sequence is never patched.
@@ -996,6 +990,8 @@ class Assembler : public ValueObject {
void BindARMv6(Label* label);
void BindARMv7(Label* label);
+ void BranchLink(const ExternalLabel* label);
+
class CodeComment : public ZoneAllocated {
public:
CodeComment(intptr_t pc_offset, const String& comment)
« no previous file with comments | « no previous file | runtime/vm/assembler_arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698