Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1207)

Unified Diff: runtime/vm/flow_graph_compiler.cc

Issue 1314883002: VM: Use constant pool also for leaf runtime calls on x64, arm, arm64 and mips. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: fixed non-simulated arm/mips build Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/flow_graph_compiler.cc
diff --git a/runtime/vm/flow_graph_compiler.cc b/runtime/vm/flow_graph_compiler.cc
index ab586c9fb5834f2acecbb0fb130f4e56963ed741..aba3d8dea6054c24c9d62e7fc3fec8695638d98e 100644
--- a/runtime/vm/flow_graph_compiler.cc
+++ b/runtime/vm/flow_graph_compiler.cc
@@ -67,6 +67,7 @@ DECLARE_FLAG(bool, use_cha_deopt);
DECLARE_FLAG(bool, use_osr);
DECLARE_FLAG(bool, warn_on_javascript_compatibility);
DECLARE_FLAG(bool, precompile_collect_closures);
+DECLARE_FLAG(bool, print_stop_message);
rmacnak 2015/08/26 23:55:24 I don't see any use of this flag.
Florian Schneider 2015/08/27 08:27:20 It's right below.
rmacnak 2015/08/27 20:14:05 Nvm, I thought this was defining a new flag.
static void NooptModeHandler(bool value) {
@@ -92,6 +93,9 @@ static void NooptModeHandler(bool value) {
// TODO(srdjan): Enable CHA deoptimization when eager class finalization is
// implemented, either with precompilation or as a special pass.
FLAG_use_cha_deopt = false;
+ // Calling the PrintStopMessage stub is not supported in precompiled code
+ // since it is done at places where no pool pointer is loaded.
+ FLAG_print_stop_message = false;
}
}

Powered by Google App Engine
This is Rietveld 408576698