Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Side by Side Diff: runtime/vm/runtime_entry_arm.cc

Issue 1314883002: VM: Use constant pool also for leaf runtime calls on x64, arm, arm64 and mips. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: use StubEntry::label directly Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/vm/flow_graph_compiler.cc ('k') | runtime/vm/runtime_entry_mips.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" 5 #include "vm/globals.h"
6 #if defined(TARGET_ARCH_ARM) 6 #if defined(TARGET_ARCH_ARM)
7 7
8 #include "vm/runtime_entry.h" 8 #include "vm/runtime_entry.h"
9 9
10 #include "vm/assembler.h" 10 #include "vm/assembler.h"
(...skipping 25 matching lines...) Expand all
36 Simulator::CallKind call_kind = 36 Simulator::CallKind call_kind =
37 is_leaf() ? (is_float() ? Simulator::kLeafFloatRuntimeCall 37 is_leaf() ? (is_float() ? Simulator::kLeafFloatRuntimeCall
38 : Simulator::kLeafRuntimeCall) 38 : Simulator::kLeafRuntimeCall)
39 : Simulator::kRuntimeCall; 39 : Simulator::kRuntimeCall;
40 entry = 40 entry =
41 Simulator::RedirectExternalReference(entry, call_kind, argument_count); 41 Simulator::RedirectExternalReference(entry, call_kind, argument_count);
42 #endif 42 #endif
43 ExternalLabel label(entry); 43 ExternalLabel label(entry);
44 if (is_leaf()) { 44 if (is_leaf()) {
45 ASSERT(argument_count == this->argument_count()); 45 ASSERT(argument_count == this->argument_count());
46 __ BranchLink(&label); 46 __ BranchLink(&label, kNotPatchable);
47 } else { 47 } else {
48 // Argument count is not checked here, but in the runtime entry for a more 48 // Argument count is not checked here, but in the runtime entry for a more
49 // informative error message. 49 // informative error message.
50 __ LoadExternalLabel(R5, &label, kNotPatchable); 50 __ LoadExternalLabel(R5, &label, kNotPatchable);
51 __ LoadImmediate(R4, argument_count); 51 __ LoadImmediate(R4, argument_count);
52 __ BranchLink(*StubCode::CallToRuntime_entry(), kNotPatchable); 52 __ BranchLink(*StubCode::CallToRuntime_entry(), kNotPatchable);
53 } 53 }
54 } 54 }
55 55
56 } // namespace dart 56 } // namespace dart
57 57
58 #endif // defined TARGET_ARCH_ARM 58 #endif // defined TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « runtime/vm/flow_graph_compiler.cc ('k') | runtime/vm/runtime_entry_mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698