Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1314873005: VisualBenchTest: Read nanobench_flags.txt (Closed)

Created:
5 years, 3 months ago by borenet
Modified:
5 years, 3 months ago
Reviewers:
djsollen
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

VisualBenchTest: Read nanobench_flags.txt BUG=skia:4093 Committed: https://skia.googlesource.com/skia/+/e5a38f0ad22d2c65c3f5b568a88a0b7224ad62d8

Patch Set 1 #

Patch Set 2 : semicolon #

Patch Set 3 : ... #

Patch Set 4 : Fix #

Patch Set 5 : Assets are in the main APK #

Total comments: 2

Patch Set 6 : Move --outResultsFile to recipe #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -2 lines) Patch
M platform_tools/android/apps/visualbench/src/main/java/com/skia/VisualBenchTestActivity.java View 1 2 3 4 5 2 chunks +22 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
borenet
5 years, 3 months ago (2015-08-31 20:20:56 UTC) #2
djsollen
https://codereview.chromium.org/1314873005/diff/80001/platform_tools/android/apps/visualbench/src/main/java/com/skia/VisualBenchTestActivity.java File platform_tools/android/apps/visualbench/src/main/java/com/skia/VisualBenchTestActivity.java (right): https://codereview.chromium.org/1314873005/diff/80001/platform_tools/android/apps/visualbench/src/main/java/com/skia/VisualBenchTestActivity.java#newcode44 platform_tools/android/apps/visualbench/src/main/java/com/skia/VisualBenchTestActivity.java:44: flags.append(" --outResultsFile /sdcard/skia_results/visualbench.json"); shouldn't the flags file just have ...
5 years, 3 months ago (2015-09-01 13:15:45 UTC) #3
borenet
https://codereview.chromium.org/1314873005/diff/80001/platform_tools/android/apps/visualbench/src/main/java/com/skia/VisualBenchTestActivity.java File platform_tools/android/apps/visualbench/src/main/java/com/skia/VisualBenchTestActivity.java (right): https://codereview.chromium.org/1314873005/diff/80001/platform_tools/android/apps/visualbench/src/main/java/com/skia/VisualBenchTestActivity.java#newcode44 platform_tools/android/apps/visualbench/src/main/java/com/skia/VisualBenchTestActivity.java:44: flags.append(" --outResultsFile /sdcard/skia_results/visualbench.json"); On 2015/09/01 13:15:45, djsollen wrote: > ...
5 years, 3 months ago (2015-09-01 14:52:57 UTC) #4
djsollen
lgtm
5 years, 3 months ago (2015-09-02 12:55:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1314873005/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1314873005/100001
5 years, 3 months ago (2015-09-02 12:58:43 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-09-02 13:04:32 UTC) #8
Message was sent while issue was closed. 
Committed patchset #6 (id:100001) as
https://skia.googlesource.com/skia/+/e5a38f0ad22d2c65c3f5b568a88a0b7224ad62d8

Powered by Google App Engine
This is Rietveld 408576698