Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Unified Diff: test/cctest/test-debug.cc

Issue 1314863003: [heap] More flag cleanup. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Added more comments Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/cctest/test-api.cc ('k') | test/cctest/test-heap.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-debug.cc
diff --git a/test/cctest/test-debug.cc b/test/cctest/test-debug.cc
index 1e3f0ab707eab90451e4c762516ad0909bf53b6e..640fafa283ec9943b97e90a56670bade12f33189 100644
--- a/test/cctest/test-debug.cc
+++ b/test/cctest/test-debug.cc
@@ -398,7 +398,8 @@ void CheckDebuggerUnloaded(bool check_functions) {
// Collect garbage to ensure weak handles are cleared.
CcTest::heap()->CollectAllGarbage();
- CcTest::heap()->CollectAllGarbage(Heap::kMakeHeapIterableMask);
+ CcTest::heap()->CollectAllGarbage("CheckDebuggerUnloaded",
+ Heap::kMakeHeapIterableMask);
// Iterate the head and check that there are no debugger related objects left.
HeapIterator iterator(CcTest::heap());
@@ -813,7 +814,7 @@ static void DebugEventBreakPointCollectGarbage(
break_point_hit_count++;
if (break_point_hit_count % 2 == 0) {
// Scavenge.
- CcTest::heap()->CollectGarbage(v8::internal::NEW_SPACE);
+ CcTest::heap()->CollectGarbageNewSpace();
} else {
// Mark sweep compact.
CcTest::heap()->CollectAllGarbage();
@@ -837,7 +838,7 @@ static void DebugEventBreak(
// Run the garbage collector to enforce heap verification if option
// --verify-heap is set.
- CcTest::heap()->CollectGarbage(v8::internal::NEW_SPACE);
+ CcTest::heap()->CollectGarbageNewSpace();
// Set the break flag again to come back here as soon as possible.
v8::Debug::DebugBreak(CcTest::isolate());
@@ -1221,7 +1222,7 @@ static void CallAndGC(v8::Local<v8::Object> recv,
CHECK_EQ(1 + i * 3, break_point_hit_count);
// Scavenge and call function.
- CcTest::heap()->CollectGarbage(v8::internal::NEW_SPACE);
+ CcTest::heap()->CollectGarbageNewSpace();
f->Call(recv, 0, NULL);
CHECK_EQ(2 + i * 3, break_point_hit_count);
« no previous file with comments | « test/cctest/test-api.cc ('k') | test/cctest/test-heap.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698