DevTools: expose wired front-end API for editors interop [blink]

DevTools: expose wired front-end API for editors interop [blink]

BUG=529471
Committed: https://crrev.com/de706cc8e7f072bdb979d025ecfb54b53fe15f9e
git-svn-id: svn://svn.chromium.org/blink/trunk@202006 bbb929c8-8fbe-4397-9dbb-9b2b20218538

[pfeldman, 2015-09-08 22:11:05]

pfeldman@chromium.org changed reviewers:
+ dgozman@chromium.org

[dgozman, 2015-09-08 22:32:16]

This is not [chrome], but [blink].

https://codereview.chromium.org/1314853006/diff/1/Source/devtools/front_end/m...
File Source/devtools/front_end/main/FrontendWebSocketAPI.js (right):

https://codereview.chromium.org/1314853006/diff/1/Source/devtools/front_end/m...
Source/devtools/front_end/main/FrontendWebSocketAPI.js:1: // Copyright 2014 The
Chromium Authors. All rights reserved.
2015

https://codereview.chromium.org/1314853006/diff/1/Source/devtools/front_end/m...
Source/devtools/front_end/main/FrontendWebSocketAPI.js:20: var message =
JSON.parse(/** @type {string} */ (event.data));
It's annotated as object in devtools.js. Why string here?

https://codereview.chromium.org/1314853006/diff/1/Source/devtools/front_end/m...
Source/devtools/front_end/main/FrontendWebSocketAPI.js:45:
InspectorFrontendHost.sendFrontendAPINotification(JSON.stringify({id: id}));
Extract this into |_respondToFrontendAPIMessage(id, result)|?

https://codereview.chromium.org/1314853006/diff/1/Source/devtools/front_end/m...
File Source/devtools/front_end/main/Main.js (right):

https://codereview.chromium.org/1314853006/diff/1/Source/devtools/front_end/m...
Source/devtools/front_end/main/Main.js:354: new
WebInspector.FrontendWebSocketAPI();
Why late? It only depends on workspace. Would be hard to test this way.

[pfeldman, 2015-09-09 00:50:30]

https://codereview.chromium.org/1314853006/diff/1/Source/devtools/front_end/m...
File Source/devtools/front_end/main/FrontendWebSocketAPI.js (right):

https://codereview.chromium.org/1314853006/diff/1/Source/devtools/front_end/m...
Source/devtools/front_end/main/FrontendWebSocketAPI.js:1: // Copyright 2014 The
Chromium Authors. All rights reserved.
On 2015/09/08 22:32:16, dgozman wrote:
> 2015

Done.

https://codereview.chromium.org/1314853006/diff/1/Source/devtools/front_end/m...
Source/devtools/front_end/main/FrontendWebSocketAPI.js:20: var message =
JSON.parse(/** @type {string} */ (event.data));
On 2015/09/08 22:32:16, dgozman wrote:
> It's annotated as object in devtools.js. Why string here?

Done.

https://codereview.chromium.org/1314853006/diff/1/Source/devtools/front_end/m...
Source/devtools/front_end/main/FrontendWebSocketAPI.js:45:
InspectorFrontendHost.sendFrontendAPINotification(JSON.stringify({id: id}));
On 2015/09/08 22:32:16, dgozman wrote:
> Extract this into |_respondToFrontendAPIMessage(id, result)|?

Acknowledged.

https://codereview.chromium.org/1314853006/diff/1/Source/devtools/front_end/m...
File Source/devtools/front_end/main/Main.js (right):

https://codereview.chromium.org/1314853006/diff/1/Source/devtools/front_end/m...
Source/devtools/front_end/main/Main.js:354: new
WebInspector.FrontendWebSocketAPI();
On 2015/09/08 22:32:16, dgozman wrote:
> Why late? It only depends on workspace. Would be hard to test this way.

To make sure we don't regress TTIE everything not essential should be
initialized from here.

[dgozman, 2015-09-09 00:58:33]

Where is a new patch set?

[dgozman, 2015-09-09 01:46:24]

lgtm

[pfeldman, 2015-09-09 20:12:05]

The CQ bit was checked by pfeldman@chromium.org

[commit-bot: I haz the power, 2015-09-09 20:12:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1314853006/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1314853006/20001

[pfeldman, 2015-09-09 20:12:23]

The CQ bit was unchecked by pfeldman@chromium.org

[pfeldman, 2015-09-09 20:47:53]

The CQ bit was checked by pfeldman@chromium.org

[pfeldman, 2015-09-09 20:47:53]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/1314853006/#ps40001
(title: " ")

[commit-bot: I haz the power, 2015-09-09 20:48:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1314853006/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1314853006/40001

[commit-bot: I haz the power, 2015-09-09 22:13:01]

Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=202006

[commit-bot: I haz the power, 2015-09-23 12:04:13]

Patchset 3 (id:??) landed as
https://crrev.com/de706cc8e7f072bdb979d025ecfb54b53fe15f9e