Chromium Code Reviews

Unified Diff: src/heap/heap.h

Issue 1314853002: [heap] Make the current GCCallbackFlags are part of {Heap}. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
« no previous file with comments | « no previous file | src/heap/heap.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/heap/heap.h
diff --git a/src/heap/heap.h b/src/heap/heap.h
index 48b0c6fe5bcfeaceee9c5521d132f070b53b15ce..70ed115e458dd79ebf88a2c82502cb073fcff2f0 100644
--- a/src/heap/heap.h
+++ b/src/heap/heap.h
@@ -1397,7 +1397,8 @@ class Heap {
// Starts incremental marking assuming incremental marking is currently
// stopped.
void StartIncrementalMarking(int gc_flags,
Hannes Payer (out of office) 2015/08/25 08:35:27 Can we make change the int gc_flags to an enum, yo
Michael Lippautz 2015/08/25 08:54:17 Acknowledged and Done.
- const GCCallbackFlags gc_callback_flags,
+ const GCCallbackFlags gc_callback_flags =
+ GCCallbackFlags::kNoGCCallbackFlags,
const char* reason = nullptr);
// Performs incremental marking steps of step_size_in_bytes as long as
@@ -1735,6 +1736,14 @@ class Heap {
!ShouldAbortIncrementalMarking());
}
+ GCCallbackFlags current_gc_callback_flags() {
+ return current_gc_callback_flags_;
+ }
+
+ void set_current_gc_callback_flags(GCCallbackFlags callback_flags) {
+ current_gc_callback_flags_ = callback_flags;
+ }
+
inline bool ShouldReduceMemory() const {
return current_gc_flags_ & kReduceMemoryFootprintMask;
}
@@ -2335,6 +2344,8 @@ class Heap {
// Currently set GC flags that are respected by all GC components.
int current_gc_flags_;
+ GCCallbackFlags current_gc_callback_flags_;
Hannes Payer (out of office) 2015/08/25 08:35:27 Describe what these flags are doing.
Michael Lippautz 2015/08/25 08:54:17 Done.
+
ExternalStringTable external_string_table_;
VisitorDispatchTable<ScavengingCallback> scavenging_visitors_table_;
« no previous file with comments | « no previous file | src/heap/heap.cc » ('j') | no next file with comments »

Powered by Google App Engine