[heap] Make the current GCCallbackFlags are part of {Heap}.

[heap] Make the current GCCallbackFlags are part of {Heap}.

Moves the GCCallbackflags where they belong, i.e., {Heap}, and gets rid of
IncrementalMarking::Start() callsites.

BUG=

Committed: https://crrev.com/1507da8d28caefdd7f95ade61bf5a6e80a333dd5
Cr-Commit-Position: refs/heads/master@{#30349}

[Hannes Payer (out of office), 2015-08-25 08:35:27]

hpayer@chromium.org changed reviewers:
+ hpayer@chromium.org

[Hannes Payer (out of office), 2015-08-25 08:35:28]

https://codereview.chromium.org/1314853002/diff/1/src/heap/heap.h
File src/heap/heap.h (right):

https://codereview.chromium.org/1314853002/diff/1/src/heap/heap.h#newcode1399
src/heap/heap.h:1399: void StartIncrementalMarking(int gc_flags,
Can we make change the int gc_flags to an enum, you can do that in a separate
cl.

The flags could also have a default parameter.

https://codereview.chromium.org/1314853002/diff/1/src/heap/heap.h#newcode2347
src/heap/heap.h:2347: GCCallbackFlags current_gc_callback_flags_;
Describe what these flags are doing.

[Michael Lippautz, 2015-08-25 08:54:17]

PTAL

https://codereview.chromium.org/1314853002/diff/1/src/heap/heap.h
File src/heap/heap.h (right):

https://codereview.chromium.org/1314853002/diff/1/src/heap/heap.h#newcode1399
src/heap/heap.h:1399: void StartIncrementalMarking(int gc_flags,
On 2015/08/25 08:35:27, Hannes Payer wrote:
> Can we make change the int gc_flags to an enum, you can do that in a separate
> cl.
> 
> The flags could also have a default parameter.

Acknowledged and Done.

https://codereview.chromium.org/1314853002/diff/1/src/heap/heap.h#newcode2347
src/heap/heap.h:2347: GCCallbackFlags current_gc_callback_flags_;
On 2015/08/25 08:35:27, Hannes Payer wrote:
> Describe what these flags are doing.

Done.

[Hannes Payer (out of office), 2015-08-25 09:21:20]

lgtm, one nit

https://codereview.chromium.org/1314853002/diff/60001/src/heap/heap.h
File src/heap/heap.h (right):

https://codereview.chromium.org/1314853002/diff/60001/src/heap/heap.h#newcode...
src/heap/heap.h:1681: 
The local variable is just used within heap. The getter/setter are not needed.

[Michael Lippautz, 2015-08-25 10:33:39]

https://codereview.chromium.org/1314853002/diff/60001/src/heap/heap.h
File src/heap/heap.h (right):

https://codereview.chromium.org/1314853002/diff/60001/src/heap/heap.h#newcode...
src/heap/heap.h:1681: 
On 2015/08/25 09:21:20, Hannes Payer wrote:
> The local variable is just used within heap. The getter/setter are not needed.

Done.

[Michael Lippautz, 2015-08-25 10:33:43]

The CQ bit was checked by mlippautz@chromium.org

[Michael Lippautz, 2015-08-25 10:33:44]

The patchset sent to the CQ was uploaded after l-g-t-m from hpayer@chromium.org
Link to the patchset: https://codereview.chromium.org/1314853002/#ps100001
(title: "rebase")

[commit-bot: I haz the power, 2015-08-25 10:33:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1314853002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1314853002/100001

[commit-bot: I haz the power, 2015-08-25 10:59:46]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2015-08-25 11:00:05]

Patchset 6 (id:??) landed as
https://crrev.com/1507da8d28caefdd7f95ade61bf5a6e80a333dd5
Cr-Commit-Position: refs/heads/master@{#30349}