chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java - Issue 1314843007: Refactor connection_security into SecurityStateModel

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java

Issue 1314843007: Refactor connection_security into SecurityStateModel (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: avi comments Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/ssl/SecurityStateModel.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/ssl/SecurityStateModel.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarModel.java » ('j') | chrome/browser/ssl/security_state_model_android.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java b/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java

index f47c28577b6c05fcbf446f683d0d996bb0f88a24..a5eff2d1de1cd79af327486aa3b2e1bdfd7dd76e 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java

@@ -58,8 +58,8 @@ import org.chromium.chrome.browser.metrics.UmaUtils;

import org.chromium.chrome.browser.printing.TabPrinter;

import org.chromium.chrome.browser.profiles.Profile;

import org.chromium.chrome.browser.snackbar.SnackbarManager;

-import org.chromium.chrome.browser.ssl.ConnectionSecurity;

import org.chromium.chrome.browser.ssl.ConnectionSecurityLevel;

+import org.chromium.chrome.browser.ssl.SecurityStateModel;

import org.chromium.chrome.browser.tab.TabUma.TabCreationState;

import org.chromium.chrome.browser.tabmodel.TabModel.TabLaunchType;

import org.chromium.chrome.browser.tabmodel.TabModel.TabSelectionType;

@@ -460,6 +460,7 @@ public class Tab implements ViewGroup.OnHierarchyChangeListener,

@Override

public void visibleSSLStateChanged() {

+ SecurityStateModel.securityStateChanged(getWebContents());

Ted C 2015/09/04 00:36:50 To avoid exposing the securityStateChanged method

estark 2015/09/04 16:53:09 Done.

for (TabObserver observer : mObservers) observer.onSSLStateUpdated(Tab.this);

}

@@ -1220,7 +1221,7 @@ public class Tab implements ViewGroup.OnHierarchyChangeListener,

// TODO(tedchoc): Remove this and transition all clients to use ToolbarModel directly.

public int getSecurityLevel() {

- return ConnectionSecurity.getSecurityLevelForWebContents(getWebContents());

+ return SecurityStateModel.getSecurityLevelForWebContents(getWebContents());

}

/**