Refactor connection_security into SecurityStateModel

content/public/browser/web_contents_delegate.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_DELEGATE_H_
 #define CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_DELEGATE_H_
 
 #include <set>
 #include <string>
 
@@ skipping 74 matching lines @@
                                       const OpenURLParams& params);
 
   // Called to inform the delegate that the WebContents's navigation state
   // changed. The |changed_flags| indicates the parts of the navigation state
   // that have been updated.
   virtual void NavigationStateChanged(WebContents* source,
                                       InvalidateTypes changed_flags) {}
 
   // Called to inform the delegate that the WebContent's visible SSL state (as
   // defined by SSLStatus) changed.
-  virtual void VisibleSSLStateChanged(const WebContents* source) {}
+  virtual void VisibleSSLStateChanged(WebContents* source) {}

[Avi (use Gerrit), 2015/09/03 22:57:36]

I'm OK with this, though if you move the SSM creation to the tab helpers, then
you probably wouldn't need this change.

[estark, 2015/09/03 23:16:40]

I think I still do need it. I believe Browser::VisibleSSLStateChanged needs a
non-const WebContents in order to get a non-const SSM in order to call
SecurityStateChanged() on it.

[Avi (use Gerrit), 2015/09/03 23:21:11]

Hmmm. Yep, that's right.

 
   // Creates a new tab with the already-created WebContents 'new_contents'.
   // The window for the added contents should be reparented correctly when this
   // method returns.  If |disposition| is NEW_POPUP, |initial_rect| should hold
   // the initial position and size. If |was_blocked| is non-nullptr, then
   // |*was_blocked| will be set to true if the popup gets blocked, and left
   // unchanged otherwise.
   virtual void AddNewContents(WebContents* source,
                               WebContents* new_contents,
                               WindowOpenDisposition disposition,
@@ skipping 406 matching lines @@
   // Called when |this| is no longer the WebContentsDelegate for |source|.
   void Detach(WebContents* source);
 
   // The WebContents that this is currently a delegate for.
   std::set<WebContents*> attached_contents_;
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_DELEGATE_H_