Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 1314843003: Replace forward class declarations of VisibleSelection to include directive (Closed)

Created:
5 years, 3 months ago by yosin_UTC9
Modified:
5 years, 3 months ago
Reviewers:
yoichio, hajimehoshi
CC:
blink-reviews, blink-reviews-style_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Replace forward class declarations of VisibleSelection to include directive This patch replaces forward class declarations |VisibleSelection| to include directive of "VisibleSelection.h" as preparation of introducing |VisibleSelectionTemplate<Strategy>|, like |PositionAlgorithm<Strategy>|. This patch is a preparation of making selection to handle granularity for web component, http://crrev.com/1277863002 BUG=513568 TEST=n/a; No behavior changes Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201215

Patch Set 1 : 2015-08-26T14:09:03 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M Source/core/editing/DOMSelection.h View 2 chunks +1 line, -1 line 0 comments Download
M Source/core/editing/EditingStyle.h View 2 chunks +1 line, -1 line 0 comments Download
M Source/core/editing/EditingUtilities.h View 2 chunks +1 line, -1 line 0 comments Download
M Source/core/editing/SelectionController.h View 2 chunks +1 line, -1 line 0 comments Download
M Source/core/editing/commands/TextInsertionBaseCommand.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
yosin_UTC9
PTAL
5 years, 3 months ago (2015-08-26 06:09:09 UTC) #2
yoichio
lgtm
5 years, 3 months ago (2015-08-26 06:12:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1314843003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1314843003/1
5 years, 3 months ago (2015-08-26 06:13:37 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/44717)
5 years, 3 months ago (2015-08-26 07:46:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1314843003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1314843003/1
5 years, 3 months ago (2015-08-26 07:51:25 UTC) #9
commit-bot: I haz the power
5 years, 3 months ago (2015-08-26 08:29:01 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201215

Powered by Google App Engine
This is Rietveld 408576698