Fix jscompile issues in remoting webapp.

Fix bugs detected by js compiler in remoting webapp.

BUG=309844
R=jamiewalch@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248572

[Jamie, 2014-02-01 01:10:05]

lgtm, but can you update the description to point out that this fixes an actual
bug? Normally when I put together a CL to fix jscompile issues, it's just a case
of adding missing type declarations to convince jscompile that correct code
really is correct, but in this case the code was broken.

[Sergey Ulanov, 2014-02-02 05:22:58]

On 2014/02/01 01:10:05, Jamie wrote:
> lgtm, but can you update the description to point out that this fixes an
actual
> bug? Normally when I put together a CL to fix jscompile issues, it's just a
case
> of adding missing type declarations to convince jscompile that correct code
> really is correct, but in this case the code was broken.

Updated description and linked to the NM bug. I didn't open a separate issue
because the bugs are minor.

[Sergey Ulanov, 2014-02-02 05:23:03]

The CQ bit was checked by sergeyu@chromium.org

[commit-bot: I haz the power, 2014-02-02 05:23:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sergeyu@chromium.org/131483011/1

[commit-bot: I haz the power, 2014-02-02 05:23:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-02 05:23:14]

Failed to apply patch for remoting/webapp/host_it2me_dispatcher.js:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  can't find file to patch at input line 6
  Perhaps you used the wrong -p or --strip option?
  The text leading up to this was:
  --------------------------
  |Index: remoting/webapp/host_it2me_dispatcher.js
  |diff --git a/remoting/webapp/host_it2me_dispatcher.js
b/remoting/webapp/host_it2me_dispatcher.js
  |index
b018db68514f88d306714f5f42615c7e63febff7..5aff33d682a1c5213a587fa6b24ba1e288bf13b4
100644
  |--- a/remoting/webapp/host_it2me_dispatcher.js
  |+++ b/remoting/webapp/host_it2me_dispatcher.js
  --------------------------
  No file to patch.  Skipping patch.
  3 out of 3 hunks ignored

Patch:       remoting/webapp/host_it2me_dispatcher.js
Index: remoting/webapp/host_it2me_dispatcher.js
diff --git a/remoting/webapp/host_it2me_dispatcher.js
b/remoting/webapp/host_it2me_dispatcher.js
index
b018db68514f88d306714f5f42615c7e63febff7..5aff33d682a1c5213a587fa6b24ba1e288bf13b4
100644
--- a/remoting/webapp/host_it2me_dispatcher.js
+++ b/remoting/webapp/host_it2me_dispatcher.js
@@ -38,6 +38,8 @@ remoting.HostIt2MeDispatcher = function() {
  *     invoke when the host state changes.
  * @param {function(boolean):void} onNatPolicyChanged Callback to invoke when
  *     the nat traversal policy changes.
+ * @param {function(string):void} logDebugInfo Callback allowing the plugin
+ *     to log messages to the debug log.
  * @param {string} xmppServerAddress XMPP server host name (or IP address) and
  *     port.
  * @param {boolean} xmppServerUseTls Whether to use TLS on connections to the
@@ -49,9 +51,11 @@ remoting.HostIt2MeDispatcher = function() {
  */
 remoting.HostIt2MeDispatcher.prototype.initAndConnect =
     function(createPluginCallback, email, authServiceWithToken, onStateChanged,
-             onNatPolicyChanged, xmppServerAddress, xmppServerUseTls,
-             directoryBotJid, onError) {
+             onNatPolicyChanged, logDebugInfo, xmppServerAddress,
+             xmppServerUseTls, directoryBotJid, onError) {
+  /** @type {remoting.HostIt2MeDispatcher} */
   var that = this;
+
   function onNativeMessagingStarted() {
     console.log('Native Messaging supported.');
     that.nativeMessagingHost_.connect(
@@ -69,7 +73,7 @@ remoting.HostIt2MeDispatcher.prototype.initAndConnect =
       that.npapiHost_.xmppServerUseTls = xmppServerUseTls;
       that.npapiHost_.directoryBotJid = directoryBotJid;
       that.npapiHost_.onStateChanged = onStateChanged;
-      that.npapiHost_.onNatTraversalPolicyChanged =
onNatTraversalPolicyChanged;
+      that.npapiHost_.onNatTraversalPolicyChanged = onNatPolicyChanged;
       that.npapiHost_.logDebugInfo = logDebugInfo;
       that.npapiHost_.localize(chrome.i18n.getMessage);
       that.npapiHost_.connect(email, authServiceWithToken);

[commit-bot: I haz the power, 2014-02-02 05:23:20]

CQ bit was unchecked on CL. Ignoring.

[commit-bot: I haz the power, 2014-02-02 05:23:23]

CQ bit was unchecked on CL. Ignoring.

[Sergey Ulanov, 2014-02-03 19:13:03]

The CQ bit was checked by sergeyu@chromium.org

[commit-bot: I haz the power, 2014-02-03 19:14:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sergeyu@chromium.org/131483011/1

[Sergey Ulanov, 2014-02-03 20:56:17]

Committed patchset #1 manually as r248572 (presubmit successful).

[commit-bot: I haz the power, 2014-02-03 20:56:18]

CQ bit was unchecked on CL. Ignoring.

[commit-bot: I haz the power, 2014-02-03 20:56:23]

CQ bit was unchecked on CL. Ignoring.

[commit-bot: I haz the power, 2014-02-03 20:56:42]

CQ bit was unchecked on CL. Ignoring.