LayoutTests/fast/dom/HTMLImageElement/image-crossOrigin-expected.txt - Issue 131483006: Correctly reflect the 'crossOrigin' attribute.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/dom/HTMLImageElement/image-crossOrigin-expected.txt

Issue 131483006: Correctly reflect the 'crossOrigin' attribute. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Remove empty line Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/fast/dom/HTMLImageElement/image-crossOrigin.html ('k') | LayoutTests/fast/dom/HTMLScriptElement/script-crossOrigin.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 This tests the handling of the img.crossOrigin attribute

	2

	3 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE ".

	4

	5

	6 PASS 'crossOrigin' in img is true

	7 PASS img.crossOrigin is ""

	8 PASS img.setAttribute('crossorigin', ''); img.crossOrigin is "anonymous"

	9 PASS img.removeAttribute('crossorigin'); img.crossOrigin is ""
	arv (Not doing code reviews) 2014/01/13 14:35:09 I found this strange but I double checked with the I found this strange but I double checked with the spec and the above seems correct.
	10 PASS img.setAttribute('crossorigin', 'foo'); img.crossOrigin is "anonymous"

	11 PASS img.setAttribute('crossorigin', 'ANONYMOUS'); img.crossOrigin is "anonymous "

	12 PASS img.setAttribute('crossorigin', 'use-credentials'); img.crossOrigin is "use -credentials"

	13 PASS img.crossOrigin = ''; img.getAttribute('crossorigin') is ""

	14 PASS img.crossOrigin = 'foo'; img.getAttribute('crossorigin') is "foo"
	arv (Not doing code reviews) 2014/01/13 14:35:09 This is also very strange. Maybe the spec should c This is also very strange. Maybe the spec should change to not change the value? sof 2014/01/13 14:45:58 I do wonder why crossOrigin wasn't given an IDL en Show quoted text On 2014/01/13 14:35:09, arv wrote: > This is also very strange. Maybe the spec should change to not change the value? I do wonder why crossOrigin wasn't given an IDL enumerated type, which would take care of this (..and more, it would throw.) (FTR, the reason why there's no filtering of the value put is from http://www.whatwg.org/specs/web-apps/current-work/#limited-to-only-known-values ";and on setting, the content atribute must be set to the specified new value.")
	15 PASS img.crossOrigin = null; img.getAttribute('crossorigin') is "null"

	16 PASS img.crossOrigin = 'ANONYMOUS'; img.getAttribute('crossorigin') is "ANONYMOU S"

	17 PASS img.crossOrigin = 'use-credentials'; img.getAttribute('crossorigin') is "us e-credentials"

	18 PASS successfullyParsed is true

	19

	20 TEST COMPLETE

	21

OLD	NEW