Revert of Reland [Startup Tracing] Add --trace-config-file flag

Revert of Reland [Startup Tracing] Add --trace-config-file flag (patchset #2 id:20001 of https://codereview.chromium.org/1317333002/ )

Reason for revert:
This CL causes problem on Win X64 GN dbg again. Not sure why. Cannot test on trybot either because there are some other trybot issues. Will revert this CL for now and wait until the waterfall is entirely green again for further testing.

http://build.chromium.org/p/chromium.win/buildstatus?builder=Win%20x64%20GN%20%28dbg%29&number=8575

Original issue's description:
> Reland [Startup Tracing] Add --trace-config-file flag
> 
> Original CL: https://codereview.chromium.org/1315463002/
> 
> This CL adds --trace-config-file flag. Please see trace_config_file.h for details.
> 
> Design doc:
> https://docs.google.com/document/d/1PgdXUOJF3WtEmYWUyGRbC2Fz2ICCZKO9jPvpLPRSHH8/edit?usp=sharing
> 
> BUG=317481, 482098
> TBR=dsinclair@chromium.org,blundell@chromium.org,sievers@chromium.org,sky@chromium.org,msw@chromium.org
> 
> Committed: https://crrev.com/a556ab616a3817468a9bd2163383dafe24ffdc96
> Cr-Commit-Position: refs/heads/master@{#346189}

TBR=dsinclair@chromium.org,blundell@chromium.org,sievers@chromium.org,msw@chromium.org,sky@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=317481, 482098

[Zhen Wang, 2015-08-28 19:14:16]

Created Revert of Reland [Startup Tracing] Add --trace-config-file flag

[commit-bot: I haz the power, 2015-08-28 19:14:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1314823005/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1314823005/1

[Zhen Wang, 2015-08-28 19:15:35]

The CQ bit was unchecked by zhenw@chromium.org

[commit-bot: I haz the power, 2015-08-28 19:15:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-28 19:15:46]

Failed to apply patch for components/tracing/trace_config_file.cc:
While running git rm components/tracing/trace_config_file.cc;
  fatal: pathspec 'components/tracing/trace_config_file.cc' did not match any
files

Patch:  D    components/tracing/trace_config_file.cc
Index: components/tracing/trace_config_file.cc
diff --git a/components/tracing/trace_config_file.cc
b/components/tracing/trace_config_file.cc
deleted file mode 100644
index
e1cbc5c391e6c98edda8f907a91c53e9d39b7e81..0000000000000000000000000000000000000000
--- a/components/tracing/trace_config_file.cc
+++ /dev/null
@@ -1,140 +0,0 @@
-// Copyright (c) 2015 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "components/tracing/trace_config_file.h"
-
-#include <string>
-
-#include "base/command_line.h"
-#include "base/files/file_util.h"
-#include "base/json/json_reader.h"
-#include "base/json/json_writer.h"
-#include "base/logging.h"
-#include "base/memory/singleton.h"
-#include "base/values.h"
-#include "components/tracing/tracing_switches.h"
-
-namespace tracing {
-
-namespace {
-
-// Maximum trace config file size that will be loaded, in bytes.
-const size_t kTraceConfigFileSizeLimit = 64 * 1024;
-
-// Trace config file path:
-// - Android: /data/local/chrome-trace-config.json
-// - Others: specified by --trace-config-file flag.
-#if defined(OS_ANDROID)
-const base::FilePath::CharType kAndroidTraceConfigFile[] =
-    FILE_PATH_LITERAL("/data/local/chrome-trace-config.json");
-#endif
-
-const base::FilePath::CharType kDefaultResultFile[] =
-    FILE_PATH_LITERAL("chrometrace.log");
-
-// String parameters that can be used to parse the trace config file content.
-const char kTraceConfigParam[] = "trace_config";
-const char kStartupDurationParam[] = "startup_duration";
-const char kResultFileParam[] = "result_file";
-
-} // namespace
-
-TraceConfigFile* TraceConfigFile::GetInstance() {
-  return Singleton<TraceConfigFile,
-                   DefaultSingletonTraits<TraceConfigFile>>::get();
-}
-
-TraceConfigFile::TraceConfigFile()
-    : is_enabled_(false),
-      trace_config_(base::trace_event::TraceConfig()),
-      startup_duration_(0),
-      result_file_(kDefaultResultFile) {
-#if defined(OS_ANDROID)
-  base::FilePath trace_config_file(kAndroidTraceConfigFile);
-#else
-  const base::CommandLine& command_line =
-      *base::CommandLine::ForCurrentProcess();
-  if (!command_line.HasSwitch(switches::kTraceConfigFile) ||
-      command_line.HasSwitch(switches::kTraceStartup) ||
-      command_line.HasSwitch(switches::kTraceShutdown)) {
-    return;
-  }
-  base::FilePath trace_config_file =
-      command_line.GetSwitchValuePath(switches::kTraceConfigFile);
-#endif
-
-  if (trace_config_file.empty()) {
-    // If the trace config file path is not specified, trace Chrome with the
-    // default configuration for 5 sec.
-    startup_duration_ = 5;
-    is_enabled_ = true;
-    return;
-  }
-
-  if (!base::PathExists(trace_config_file))
-    return;
-
-  std::string trace_config_file_content;
-  if (!base::ReadFileToString(trace_config_file,
-                              &trace_config_file_content,
-                              kTraceConfigFileSizeLimit)) {
-    return;
-  }
-  is_enabled_ = ParseTraceConfigFileContent(trace_config_file_content);
-}
-
-TraceConfigFile::~TraceConfigFile() {
-}
-
-bool TraceConfigFile::ParseTraceConfigFileContent(std::string content) {
-  scoped_ptr<base::Value> value(base::JSONReader::Read(content));
-  if (!value || !value->IsType(base::Value::TYPE_DICTIONARY))
-    return false;
-
-  scoped_ptr<base::DictionaryValue> dict(
-      static_cast<base::DictionaryValue*>(value.release()));
-
-  base::DictionaryValue* trace_config_dict = NULL;
-  if (!dict->GetDictionary(kTraceConfigParam, &trace_config_dict))
-    return false;
-
-  std::string trace_config_str;
-  base::JSONWriter::Write(*trace_config_dict, &trace_config_str);
-  trace_config_ = base::trace_event::TraceConfig(trace_config_str);
-
-  if (!dict->GetInteger(kStartupDurationParam, &startup_duration_))
-      startup_duration_ = 0;
-
-  if (startup_duration_ < 0)
-      startup_duration_ = 0;
-
-  std::string result_file_str;
-  if (dict->GetString(kResultFileParam, &result_file_str))
-    result_file_ = base::FilePath().AppendASCII(result_file_str);
-
-  return true;
-}
-
-bool TraceConfigFile::IsEnabled() const {
-  return is_enabled_;
-}
-
-base::trace_event::TraceConfig TraceConfigFile::GetTraceConfig() const {
-  DCHECK(IsEnabled());
-  return trace_config_;
-}
-
-int TraceConfigFile::GetStartupDuration() const {
-  DCHECK(IsEnabled());
-  return startup_duration_;
-}
-
-#if !defined(OS_ANDROID)
-base::FilePath TraceConfigFile::GetResultFile() const {
-  DCHECK(IsEnabled());
-  return result_file_;
-}
-#endif
-
-}  // namespace tracing

[commit-bot: I haz the power, 2015-08-28 19:15:57]

The CQ bit was unchecked by commit-bot@chromium.org

[Zhen Wang, 2015-08-28 19:16:33]

zhenw@chromium.org changed reviewers:
+ sergeyv@chromium.org

[Zhen Wang, 2015-08-28 19:16:33]

has been reverted by sergeyv. closing this.