content/shell/android/linker_test_apk/chromium_linker_test_linker_tests.cc - Issue 1314823003: Make Linker.isUsed() static, and clean up the fallout.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/android/linker_test_apk/chromium_linker_test_linker_tests.cc

Issue 1314823003: Make Linker.isUsed() static, and clean up the fallout. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Tiny log tweak, protected->private, rebase to master. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/shell/android/BUILD.gn ('k') | content/shell/android/linker_test_apk/src/org/chromium/chromium_linker_test_apk/ChromiumLinkerTestActivity.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/shell/android/linker_test_apk/chromium_linker_test_linker_tests.cc

diff --git a/content/shell/android/linker_test_apk/chromium_linker_test_linker_tests.cc b/content/shell/android/linker_test_apk/chromium_linker_test_linker_tests.cc

index f93ee6d1e605011786b748b335110c8e661be76e..167d926a723ccb68d61966ded15459758979d618 100644

--- a/content/shell/android/linker_test_apk/chromium_linker_test_linker_tests.cc

+++ b/content/shell/android/linker_test_apk/chromium_linker_test_linker_tests.cc

@@ -79,8 +79,8 @@ jboolean RunChecks(bool in_browser_process, bool need_relros) {

const RE2 legacy_linker_re(kLegacyRelroSectionPattern);

const RE2 modern_linker_re(kModernRelroSectionPattern);

- size_t num_shared_relros = 0;

- size_t num_bad_shared_relros = 0;

+ int num_shared_relros = 0;

+ int num_bad_shared_relros = 0;

for (size_t n = 0; n < regions.size(); ++n) {

MappedMemoryRegion& region = regions[n];