Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Issue 1314803005: Revert of Reland #1 "ipc: Add a new field num_brokered_attachments to the message header." (Closed)

Created:
5 years, 3 months ago by erikchen
Modified:
5 years, 3 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Reland #1 "ipc: Add a new field num_brokered_attachments to the message header." (patchset #4 id:60001 of https://codereview.chromium.org/1330563002/ ) Reason for revert: This CL was only ever intended to make it into one Canary. Original issue's description: > Reland #1 "ipc: Add a new field num_brokered_attachments to the message header." > > This otherwise innocuous CL is causing an unusual crash in Canary. At first > glance, the crash appears related to IPC, but further digging indicates that > it's probably related to corruption of a ResourceBuffer. I've updated that class > to use CHECKs instead of DCHECKs https://codereview.chromium.org/1325153002/. > > I expect this CL to cause ~100 crashes in the next Chrome Canary. I intend to > revert this CL after a single Canary release. This CL will help me better > diagnose the exact nature of the crash. > > BUG=493414 > > Committed: https://crrev.com/d32c32bef61d80f68208e550ace18f50f1c498d1 > Cr-Commit-Position: refs/heads/master@{#347250} TBR=tsepez@chromium.org,avi@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=493414 Committed: https://crrev.com/3086a2e4a27aa39f38b7c5aab6bf8c2815092adf Cr-Commit-Position: refs/heads/master@{#347429}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -29 lines) Patch
M content/browser/loader/async_resource_handler.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M content/child/resource_dispatcher.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M ipc/ipc_message.h View 2 chunks +0 lines, -7 lines 0 comments Download
M ipc/ipc_message.cc View 3 chunks +0 lines, -12 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
erikchen
Created Revert of Reland #1 "ipc: Add a new field num_brokered_attachments to the message header."
5 years, 3 months ago (2015-09-04 16:56:40 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1314803005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1314803005/1
5 years, 3 months ago (2015-09-04 16:56:53 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-04 16:57:42 UTC) #3
commit-bot: I haz the power
5 years, 3 months ago (2015-09-04 16:58:31 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3086a2e4a27aa39f38b7c5aab6bf8c2815092adf
Cr-Commit-Position: refs/heads/master@{#347429}

Powered by Google App Engine
This is Rietveld 408576698