content/renderer/media/media_stream_audio_processor_unittest.cc - Issue 1314803003: Include default communication devices in audio device enumerations. This removes heuristic that pic…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/media_stream_audio_processor_unittest.cc

Issue 1314803003: Include default communication devices in audio device enumerations. This removes heuristic that pic… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/media/media_stream_audio_processor_options.cc ('k') | content/renderer/media/media_stream_dispatcher.h » ('j') | content/renderer/media/webrtc_audio_renderer.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/media/media_stream_audio_processor_unittest.cc

diff --git a/content/renderer/media/media_stream_audio_processor_unittest.cc b/content/renderer/media/media_stream_audio_processor_unittest.cc

index 5a1d7a84c705966534ebb7e1b7bafffc27a77854..0e40ece9e5c4982c0b745540fe0c90dbf90a641a 100644

--- a/content/renderer/media/media_stream_audio_processor_unittest.cc

+++ b/content/renderer/media/media_stream_audio_processor_unittest.cc

@@ -337,7 +337,7 @@ TEST_F(MediaStreamAudioProcessorTest, VerifyConstraints) {

{

// When |kEchoCancellation| is explicitly set to false, the default values

- // for all the constraints except |kMediaStreamAudioDucking| are false.

+ // for all the constraints are false.

MockMediaConstraintFactory constraint_factory;

constraint_factory.AddOptional(MediaAudioConstraints::kEchoCancellation,

false);

@@ -347,11 +347,6 @@ TEST_F(MediaStreamAudioProcessorTest, VerifyConstraints) {

for (size_t i = 0; i < arraysize(kDefaultAudioConstraints); ++i) {

EXPECT_FALSE(audio_constraints.GetProperty(kDefaultAudioConstraints[i]));

}

-#if defined(OS_WIN)

- EXPECT_TRUE(audio_constraints.GetProperty(kMediaStreamAudioDucking));

-#else

- EXPECT_FALSE(audio_constraints.GetProperty(kMediaStreamAudioDucking));

-#endif

}

{