Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Side by Side Diff: media/audio/audio_manager_base.h

Issue 1314803003: Include default communication devices in audio device enumerations. This removes heuristic that pic… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comment Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef MEDIA_AUDIO_AUDIO_MANAGER_BASE_H_ 5 #ifndef MEDIA_AUDIO_AUDIO_MANAGER_BASE_H_
6 #define MEDIA_AUDIO_AUDIO_MANAGER_BASE_H_ 6 #define MEDIA_AUDIO_AUDIO_MANAGER_BASE_H_
7 7
8 #include <string> 8 #include <string>
9 #include <utility> 9 #include <utility>
10 10
(...skipping 17 matching lines...) Expand all
28 // AudioManagerBase provides AudioManager functions common for all platforms. 28 // AudioManagerBase provides AudioManager functions common for all platforms.
29 class MEDIA_EXPORT AudioManagerBase : public AudioManager { 29 class MEDIA_EXPORT AudioManagerBase : public AudioManager {
30 public: 30 public:
31 // TODO(sergeyu): The constants below belong to AudioManager interface, not 31 // TODO(sergeyu): The constants below belong to AudioManager interface, not
32 // to the base implementation. 32 // to the base implementation.
33 33
34 // Name of the generic "default" device. 34 // Name of the generic "default" device.
35 static const char kDefaultDeviceName[]; 35 static const char kDefaultDeviceName[];
36 // Unique Id of the generic "default" device. 36 // Unique Id of the generic "default" device.
37 static const char kDefaultDeviceId[]; 37 static const char kDefaultDeviceId[];
38 // Unique Id of the generic default communications device (where supported).
39 static const char kCommunicationsDeviceId[];
40 // Name of the generic default communications device (where supported).
41 static const char kCommunicationsDeviceName[];
38 42
39 // Input device ID used to capture the default system playback stream. When 43 // Input device ID used to capture the default system playback stream. When
40 // this device ID is passed to MakeAudioInputStream() the returned 44 // this device ID is passed to MakeAudioInputStream() the returned
41 // AudioInputStream will be capturing audio currently being played on the 45 // AudioInputStream will be capturing audio currently being played on the
42 // default playback device. At the moment this feature is supported only on 46 // default playback device. At the moment this feature is supported only on
43 // some platforms. AudioInputStream::Intialize() will return an error on 47 // some platforms. AudioInputStream::Intialize() will return an error on
44 // platforms that don't support it. GetInputStreamParameters() must be used 48 // platforms that don't support it. GetInputStreamParameters() must be used
45 // to get the parameters of the loopback device before creating a loopback 49 // to get the parameters of the loopback device before creating a loopback
46 // stream, otherwise stream initialization may fail. 50 // stream, otherwise stream initialization may fail.
47 static const char kLoopbackInputDeviceId[]; 51 static const char kLoopbackInputDeviceId[];
(...skipping 134 matching lines...) Expand 10 before | Expand all | Expand 10 after
182 186
183 // Proxy for creating AudioLog objects. 187 // Proxy for creating AudioLog objects.
184 AudioLogFactory* const audio_log_factory_; 188 AudioLogFactory* const audio_log_factory_;
185 189
186 DISALLOW_COPY_AND_ASSIGN(AudioManagerBase); 190 DISALLOW_COPY_AND_ASSIGN(AudioManagerBase);
187 }; 191 };
188 192
189 } // namespace media 193 } // namespace media
190 194
191 #endif // MEDIA_AUDIO_AUDIO_MANAGER_BASE_H_ 195 #endif // MEDIA_AUDIO_AUDIO_MANAGER_BASE_H_
OLDNEW
« no previous file with comments | « content/renderer/media/webrtc_local_audio_renderer.cc ('k') | media/audio/audio_manager_base.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698