Include default communication devices in audio device enumerations. This removes heuristic that pic…

content/renderer/media/media_stream_audio_processor_options.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/media/media_stream_audio_processor_options.h"
 
 #include "base/files/file_path.h"
 #include "base/files/file_util.h"
 #include "base/logging.h"
 #include "base/metrics/field_trial.h"
@@ skipping 48 matching lines @@
   // Enable the extended filter mode AEC on all non-mobile platforms.
   { MediaAudioConstraints::kGoogExperimentalEchoCancellation, true },
 #endif
   { MediaAudioConstraints::kGoogAutoGainControl, true },
   { MediaAudioConstraints::kGoogExperimentalAutoGainControl, true },
   { MediaAudioConstraints::kGoogNoiseSuppression, true },
   { MediaAudioConstraints::kGoogHighpassFilter, true },
   { MediaAudioConstraints::kGoogTypingNoiseDetection, true },
   { MediaAudioConstraints::kGoogExperimentalNoiseSuppression, false },
   { MediaAudioConstraints::kGoogBeamforming, false },
-#if defined(OS_WIN)
-  { kMediaStreamAudioDucking, true },
-#else
-  { kMediaStreamAudioDucking, false },
-#endif
   { kMediaStreamAudioHotword, false },
 };
 
-bool IsAudioProcessingConstraint(const std::string& key) {
-  // |kMediaStreamAudioDucking| does not require audio processing.
-  return key != kMediaStreamAudioDucking;
-}
-
 // Used to log echo quality based on delay estimates.
 enum DelayBasedEchoQuality {
   DELAY_BASED_ECHO_QUALITY_GOOD = 0,
   DELAY_BASED_ECHO_QUALITY_SPURIOUS,
   DELAY_BASED_ECHO_QUALITY_BAD,
   DELAY_BASED_ECHO_QUALITY_INVALID,
   DELAY_BASED_ECHO_QUALITY_MAX
 };
 
 DelayBasedEchoQuality EchoDelayFrequencyToQuality(float delay_frequency) {
@@ skipping 114 matching lines @@
       return false;
     }
   }
 
   return true;
 }
 
 bool MediaAudioConstraints::GetDefaultValueForConstraint(
     const blink::WebMediaConstraints& constraints,
     const std::string& key) const {
-  // |kMediaStreamAudioDucking| is not restricted by
-  // |default_audio_processing_constraint_value_| since it does not require
-  // audio processing.
-  if (!default_audio_processing_constraint_value_ &&
-      IsAudioProcessingConstraint(key))
+  if (!default_audio_processing_constraint_value_)
     return false;
 
   for (size_t i = 0; i < arraysize(kDefaultAudioConstraints); ++i) {
     if (kDefaultAudioConstraints[i].key == key)
       return kDefaultAudioConstraints[i].value;
   }
 
   return false;
 }
 
@@ skipping 186 matching lines @@
   geometry.reserve(float_tokens.size() / 3);
   for (size_t i = 0; i < float_tokens.size(); i += 3) {
     geometry.push_back(webrtc::Point(float_tokens[i + 0], float_tokens[i + 1],
                                      float_tokens[i + 2]));
   }
 
   return geometry;
 }
 
 }  // namespace content