Source/core/html/HTMLVideoElement.cpp - Issue 1314793010: Support fragment URLs for all kinds of SVG images

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLVideoElement.cpp

Issue 1314793010: Support fragment URLs for all kinds of SVG images (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Update DEPS to match Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/fetch/ImageResource.cpp ('K') | « Source/core/html/HTMLImageElement.cpp ('k') | Source/core/html/forms/ImageInputType.cpp » ('j') | Source/core/style/StyleFetchedImageSet.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/html/HTMLVideoElement.cpp

diff --git a/Source/core/html/HTMLVideoElement.cpp b/Source/core/html/HTMLVideoElement.cpp

index e64a10fd0aa63fa70bd7c1a0daedc0f29a5d553a..54e3b123ca538de770aa1a065073eeb3c3cdc42f 100644

--- a/Source/core/html/HTMLVideoElement.cpp

+++ b/Source/core/html/HTMLVideoElement.cpp

@@ -91,7 +91,7 @@ void HTMLVideoElement::attach(const AttachContext& context)

m_imageLoader = HTMLImageLoader::create(this);

m_imageLoader->updateFromElement();

if (layoutObject())

- toLayoutImage(layoutObject())->imageResource()->setImageResource(m_imageLoader->image());

+ toLayoutImage(layoutObject())->imageResource()->setImageResource(m_imageLoader->image(), document().completeURL(posterImageURL()));

}

@@ -128,7 +128,7 @@ void HTMLVideoElement::parseAttribute(const QualifiedName& name, const AtomicStr

m_imageLoader->updateFromElement(ImageLoader::UpdateIgnorePreviousError);

} else {

if (layoutObject())

- toLayoutImage(layoutObject())->imageResource()->setImageResource(0);

+ toLayoutImage(layoutObject())->imageResource()->setImageResource(0, KURL());

}

// Notify the player when the poster image URL changes.

if (webMediaPlayer())

« Source/core/fetch/ImageResource.cpp ('K') | « Source/core/html/HTMLImageElement.cpp ('k') | Source/core/html/forms/ImageInputType.cpp » ('j') | Source/core/style/StyleFetchedImageSet.h » ('J')