Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1314793002: Oilpan: Split Heap.h into two files (Closed)

Created:
5 years, 3 months ago by haraken
Modified:
5 years, 3 months ago
Reviewers:
keishi
CC:
blink-reviews, haraken, oilpan-reviews, kouhei+heap_chromium.org, Mads Ager (chromium)
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Oilpan: Split Heap.h into two files To reduce a mess of Heap.h, this CL splits Heap.h into Heap.h and HeapPage.h. This CL just moves code around without any behavioral change. BUG=437144 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201109

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -3886 lines) Patch
M Source/platform/heap/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/platform/heap/Heap.h View 3 chunks +10 lines, -902 lines 0 comments Download
M Source/platform/heap/Heap.cpp View 4 chunks +0 lines, -1770 lines 0 comments Download
A + Source/platform/heap/HeapPage.h View 6 chunks +11 lines, -481 lines 0 comments Download
A + Source/platform/heap/HeapPage.cpp View 4 chunks +2 lines, -733 lines 0 comments Download
M Source/platform/heap/blink_heap.gypi View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 23 (10 generated)
haraken
PTAL
5 years, 3 months ago (2015-08-25 01:35:50 UTC) #2
keishi
LGTM
5 years, 3 months ago (2015-08-25 02:07:30 UTC) #3
keishi
LGTM
5 years, 3 months ago (2015-08-25 02:07:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1314793002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1314793002/1
5 years, 3 months ago (2015-08-25 02:08:05 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/103520)
5 years, 3 months ago (2015-08-25 02:46:52 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1314793002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1314793002/1
5 years, 3 months ago (2015-08-25 03:30:48 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/103573)
5 years, 3 months ago (2015-08-25 04:31:08 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1314793002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1314793002/1
5 years, 3 months ago (2015-08-25 04:41:32 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/103603)
5 years, 3 months ago (2015-08-25 05:41:52 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1314793002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1314793002/1
5 years, 3 months ago (2015-08-25 05:43:39 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/103629)
5 years, 3 months ago (2015-08-25 06:49:21 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1314793002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1314793002/1
5 years, 3 months ago (2015-08-25 06:51:50 UTC) #22
commit-bot: I haz the power
5 years, 3 months ago (2015-08-25 08:08:49 UTC) #23
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201109

Powered by Google App Engine
This is Rietveld 408576698