Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 1314783010: DevTools: fix race conditions while recording film strips (Closed)

Created:
5 years, 3 months ago by caseq
Modified:
5 years, 3 months ago
Reviewers:
dgozman, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

DevTools: fix race conditions while recording film strips - introduce ResourceTreeModel.{suspendReload,resumeReload} to temporarily suspend page reloading; - use the former to disable page reload for the period we fetch trace in the network FilmStripRecorder, as we can't start tracing while still retrieving traces; - disregard DeferredTempFile writes after file was deleted; - properly indicate frames are being recorded in FilmStripView when reload happens during frame recording. This gets rid of "Tracing is already started" and other errors while repeatedly reloading a network panel with screenshot recording on. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201837

Patch Set 1 #

Patch Set 2 : use counter, not a flag to track reload suspension #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -3 lines) Patch
M Source/devtools/front_end/bindings/TempFile.js View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/devtools/front_end/network/NetworkPanel.js View 4 chunks +6 lines, -3 lines 0 comments Download
M Source/devtools/front_end/sdk/ResourceTreeModel.js View 1 2 chunks +20 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
caseq
5 years, 3 months ago (2015-09-04 19:09:12 UTC) #2
caseq
ptal
5 years, 3 months ago (2015-09-04 21:48:09 UTC) #3
dgozman
lgtm
5 years, 3 months ago (2015-09-04 21:53:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1314783010/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1314783010/20001
5 years, 3 months ago (2015-09-04 21:54:14 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-05 01:03:43 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201837

Powered by Google App Engine
This is Rietveld 408576698