Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Side by Side Diff: net/http/http_basic_stream.h

Issue 1314783007: Added and implemented HttpStream::GetTotalSentBytes for basic streams. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed mmenke comments Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | net/http/http_basic_stream.cc » ('j') | net/http/http_basic_stream.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // HttpBasicStream is a simple implementation of HttpStream. It assumes it is 5 // HttpBasicStream is a simple implementation of HttpStream. It assumes it is
6 // not sharing a sharing with any other HttpStreams, therefore it just reads and 6 // not sharing a sharing with any other HttpStreams, therefore it just reads and
7 // writes directly to the Http Stream. 7 // writes directly to the Http Stream.
8 8
9 #ifndef NET_HTTP_HTTP_BASIC_STREAM_H_ 9 #ifndef NET_HTTP_HTTP_BASIC_STREAM_H_
10 #define NET_HTTP_HTTP_BASIC_STREAM_H_ 10 #define NET_HTTP_HTTP_BASIC_STREAM_H_
11 11
12 #include <stdint.h>
13
12 #include <string> 14 #include <string>
13 15
14 #include "base/basictypes.h" 16 #include "base/basictypes.h"
15 #include "net/http/http_basic_state.h" 17 #include "net/http/http_basic_state.h"
16 #include "net/http/http_stream.h" 18 #include "net/http/http_stream.h"
17 19
18 namespace net { 20 namespace net {
19 21
20 class BoundNetLog; 22 class BoundNetLog;
21 class ClientSocketHandle; 23 class ClientSocketHandle;
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
59 bool CanFindEndOfResponse() const override; 61 bool CanFindEndOfResponse() const override;
60 62
61 bool IsConnectionReused() const override; 63 bool IsConnectionReused() const override;
62 64
63 void SetConnectionReused() override; 65 void SetConnectionReused() override;
64 66
65 bool IsConnectionReusable() const override; 67 bool IsConnectionReusable() const override;
66 68
67 int64 GetTotalReceivedBytes() const override; 69 int64 GetTotalReceivedBytes() const override;
68 70
71 int64_t GetTotalSentBytes() const override;
Bence 2015/09/01 13:45:29 GetTotalReceivedBytes and GetTotalSentBytes should
mmenke 2015/09/01 17:39:43 I completely missed that, thanks for catching it.
sclittle 2015/09/01 20:03:00 Sure. Do you mind if I keep GetTotalSentBytes as i
mmenke 2015/09/01 20:09:07 Works for me
72
69 bool GetLoadTimingInfo(LoadTimingInfo* load_timing_info) const override; 73 bool GetLoadTimingInfo(LoadTimingInfo* load_timing_info) const override;
70 74
71 void GetSSLInfo(SSLInfo* ssl_info) override; 75 void GetSSLInfo(SSLInfo* ssl_info) override;
72 76
73 void GetSSLCertRequestInfo(SSLCertRequestInfo* cert_request_info) override; 77 void GetSSLCertRequestInfo(SSLCertRequestInfo* cert_request_info) override;
74 78
75 bool IsSpdyHttpStream() const override; 79 bool IsSpdyHttpStream() const override;
76 80
77 void Drain(HttpNetworkSession* session) override; 81 void Drain(HttpNetworkSession* session) override;
78 82
79 void SetPriority(RequestPriority priority) override; 83 void SetPriority(RequestPriority priority) override;
80 84
81 private: 85 private:
82 HttpStreamParser* parser() const { return state_.parser(); } 86 HttpStreamParser* parser() const { return state_.parser(); }
83 87
84 HttpBasicState state_; 88 HttpBasicState state_;
85 89
86 DISALLOW_COPY_AND_ASSIGN(HttpBasicStream); 90 DISALLOW_COPY_AND_ASSIGN(HttpBasicStream);
87 }; 91 };
88 92
89 } // namespace net 93 } // namespace net
90 94
91 #endif // NET_HTTP_HTTP_BASIC_STREAM_H_ 95 #endif // NET_HTTP_HTTP_BASIC_STREAM_H_
OLDNEW
« no previous file with comments | « no previous file | net/http/http_basic_stream.cc » ('j') | net/http/http_basic_stream.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698