Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1314783002:
Made all const methods on CSSPrimitiveValue have the const keyword (Closed)
|
Created:
5 years, 4 months ago by sashab Modified:
5 years, 3 months ago Reviewers:
Timothy Loh CC:
blink-reviews, dglazkov+blink, rwlbuis, apavlov+blink_chromium.org, blink-reviews-css, darktears, shans, esprehn Base URL:
https://chromium.googlesource.com/chromium/blink.git@split_out_quad Target Ref:
refs/heads/master Project:
blink Visibility:
Public. |
DescriptionMade all const methods on CSSPrimitiveValue have the const keyword
Updated all const methods on CSSPrimitiveValue to actually use the
const keyword. This is needed for later work that calls methods on const
references of CSSPrimitiveValue.
BUG=523893
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201290
Patch Set 1 #Patch Set 2 : Rebase branch onto master #
Messages
Total messages: 36 (20 generated)
sashab@chromium.org changed reviewers: + shans@chromium.org
sashab@chromium.org changed reviewers: + timloh@chromium.org - shans@chromium.org
Sorry tim; meant to put you as reviewer.
lgtm (CSSPrimitiveValues are immutable anyway, so every method can be const...)
The CQ bit was checked by sashab@chromium.org
The CQ bit was unchecked by sashab@chromium.org
The CQ bit was checked by sashab@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1314783002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1314783002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by sashab@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1314783002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1314783002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by sashab@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1314783002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1314783002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by sashab@chromium.org
The CQ bit was unchecked by sashab@chromium.org
The CQ bit was checked by sashab@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1314783002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1314783002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by sashab@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1314783002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1314783002/1
The CQ bit was unchecked by sashab@chromium.org
The CQ bit was checked by sashab@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from timloh@chromium.org Link to the patchset: https://codereview.chromium.org/1314783002/#ps20001 (title: "Rebase branch onto master")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1314783002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1314783002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by sashab@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1314783002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1314783002/20001
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://src.chromium.org/viewvc/blink?view=rev&revision=201290 |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
