Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 1314773005: Throw errors for nested targets in GN. (Closed)

Created:
5 years, 3 months ago by brettw
Modified:
5 years, 3 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Throw errors for nested targets in GN. People sometimes nest targets or configs, usually with the assumption that this limits the visibility of a config to within a target. But this nesting provides no visibility restrictions over declaring it outside of a block. For clarity, force certain types of blocks to be non-nested. Adds missing ordering documentation to the ldflags variable. Committed: https://crrev.com/a88eb18a5cb883cbde7a1e055958642a8dafb4ac Cr-Commit-Position: refs/heads/master@{#348186}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -1 line) Patch
M tools/gn/function_template.cc View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
M tools/gn/function_toolchain.cc View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M tools/gn/functions.h View 1 2 1 chunk +36 lines, -0 lines 0 comments Download
M tools/gn/functions.cc View 1 2 3 chunks +44 lines, -0 lines 0 comments Download
M tools/gn/functions_target.cc View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M tools/gn/variables.cc View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 17 (5 generated)
brettw
I'll land this after updating the current set of errors: https://codereview.chromium.org/1318823008/ and 2 deps rolls.
5 years, 3 months ago (2015-08-31 19:28:35 UTC) #1
brettw
I'll land this after updating the current set of errors: https://codereview.chromium.org/1318823008/ and 2 deps rolls.
5 years, 3 months ago (2015-08-31 19:28:46 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1314773005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1314773005/20001
5 years, 3 months ago (2015-08-31 19:29:26 UTC) #5
brettw
Hold off for a sec, I have a tweak.
5 years, 3 months ago (2015-08-31 19:30:21 UTC) #6
brettw
Ready to go again, slightly simplified.
5 years, 3 months ago (2015-08-31 19:37:43 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1314773005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1314773005/40001
5 years, 3 months ago (2015-08-31 19:38:22 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-08-31 19:53:44 UTC) #11
Dirk Pranke
lgtm
5 years, 3 months ago (2015-08-31 20:15:27 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1314773005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1314773005/40001
5 years, 3 months ago (2015-09-10 17:57:46 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 3 months ago (2015-09-10 18:11:58 UTC) #15
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/a88eb18a5cb883cbde7a1e055958642a8dafb4ac Cr-Commit-Position: refs/heads/master@{#348186}
5 years, 3 months ago (2015-09-10 18:12:37 UTC) #16
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:12:05 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/a88eb18a5cb883cbde7a1e055958642a8dafb4ac
Cr-Commit-Position: refs/heads/master@{#348186}

Powered by Google App Engine
This is Rietveld 408576698