src/opts/SkColorCubeFilter_opts.h - Issue 1314763007: SkColorCubeFilter_opts: start with a statically-initializable zero.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/opts/SkColorCubeFilter_opts.h

Issue 1314763007: SkColorCubeFilter_opts: start with a statically-initializable zero. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/opts/SkColorCubeFilter_opts.h

diff --git a/src/opts/SkColorCubeFilter_opts.h b/src/opts/SkColorCubeFilter_opts.h

index a61f66d17418d94406fcf02918f0422477b2a040..41d2525b5a387a8df89bf017f0e22a59eb3bbae6 100644

--- a/src/opts/SkColorCubeFilter_opts.h

+++ b/src/opts/SkColorCubeFilter_opts.h

@@ -51,7 +51,7 @@ void color_cube_filter_span(const SkPMColor src[],

const int i10 = (colorToIndex[1][g] + colorToIndex[0][b] * dim) * dim;

const int i11 = (colorToIndex[1][g] + colorToIndex[1][b] * dim) * dim;

- SkPMFloat color(0);

+ SkPMFloat color(0,0,0,0);

Noel Gordon 2015/08/27 13:31:50 My earlier test patches did it this way too. Agree

for (int x = 0; x < 2; ++x) {

const int ix = colorToIndex[x][r];

« no previous file with comments | « no previous file | no next file » | no next file with comments »