Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(828)

Issue 1314763003: Flakyness: fix webmidi/send-messages.html (Closed)

Created:
5 years, 3 months ago by mlamouri (slow - plz ping)
Modified:
5 years, 3 months ago
Reviewers:
whywhat, Lalit Maganti
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Flakyness: fix webmidi/send-messages.html This is using the new PermissionsHelper.setPermission() method that prevents race conditions when trying to use testRunner.setPermission. BUG=519008 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201150

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/webmidi/send-messages.html View 3 chunks +5 lines, -4 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 8 (3 generated)
mlamouri (slow - plz ping)
5 years, 3 months ago (2015-08-25 20:08:25 UTC) #2
mlamouri (slow - plz ping)
5 years, 3 months ago (2015-08-25 20:08:33 UTC) #4
whywhat
lgtm
5 years, 3 months ago (2015-08-25 20:09:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1314763003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1314763003/1
5 years, 3 months ago (2015-08-25 20:34:36 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-08-25 20:51:47 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201150

Powered by Google App Engine
This is Rietveld 408576698