[Android] Adding JavaLongArrayToInt64Vector method

[Android] Adding JavaLongArrayToInt64Vector method

Adding JavaLongArrayToInt64Vector method to provide symmetry for ToJavaLongArray

The problem is that on android_arm64_debug_recipe compilation fais for the following code:

jlongArray bookmark_ids_array;
std::vector<jlong> bookmark_ids;

base::android::JavaLongArrayToLongVector(
    env, bookmark_ids_array, &bookmark_ids);

offline_page_model_->DeletePagesByBookmarkId(
    bookmark_ids, ...)

Where expected type of first parameter in the DeletePAgesbyBookmarkId is std::vector<int64>, because int64 != jlong

int64 == int64_t == long int
jlong == long long int

This blocks: https://codereview.chromium.org/1307753002/

Sample failure: http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_dbg_recipe/builds/110589

Committed: https://crrev.com/59ab07f3f378da67847072b6d51958ce997a2102
Cr-Commit-Position: refs/heads/master@{#345675}

[fgorski, 2015-08-25 00:07:47]

fgorski@chromium.org changed reviewers:
+ nyquist@chromium.org

[fgorski, 2015-08-25 00:07:47]

Tommy,

Please take a look.

Thanks.
Filip

[fgorski, 2015-08-25 00:22:22]

On 2015/08/25 00:07:47, fgorski wrote:
> Tommy,
> 
> Please take a look.
> 
> Thanks.
> Filip

Also, this patch seems to fail for the same reason as described in the issue.
dskiba@ suggests defining HAVE_INTTYPES_H could fix the problem, I am testing
that on a side.

https://codereview.chromium.org/1314763002/

[DmitrySkiba, 2015-08-25 14:31:44]

https://codereview.chromium.org/1314753002/diff/1/base/android/jni_array.cc
File base/android/jni_array.cc (right):

https://codereview.chromium.org/1314753002/diff/1/base/android/jni_array.cc#n...
base/android/jni_array.cc:196: env->GetLongArrayRegion(long_array, 0, len,
&(*out)[0]);
Hmm, this should produce a warning because GetLongArrayRegion() expects jlong*,
but we are passing int64* without a cast.

[fgorski, 2015-08-25 18:37:55]

Thanks, Dmitry, Testing updated version now.

https://codereview.chromium.org/1314753002/diff/1/base/android/jni_array.cc
File base/android/jni_array.cc (right):

https://codereview.chromium.org/1314753002/diff/1/base/android/jni_array.cc#n...
base/android/jni_array.cc:196: env->GetLongArrayRegion(long_array, 0, len,
&(*out)[0]);
On 2015/08/25 14:31:44, dskiba wrote:
> Hmm, this should produce a warning because GetLongArrayRegion() expects
jlong*,
> but we are passing int64* without a cast.

Good point, I am testing the updated version now.

[nyquist, 2015-08-26 05:14:19]

lgtm

[fgorski, 2015-08-26 20:15:56]

The CQ bit was checked by fgorski@chromium.org

[commit-bot: I haz the power, 2015-08-26 20:16:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1314753002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1314753002/60001

[commit-bot: I haz the power, 2015-08-26 21:06:42]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-08-26 21:08:02]

Patchset 4 (id:??) landed as
https://crrev.com/59ab07f3f378da67847072b6d51958ce997a2102
Cr-Commit-Position: refs/heads/master@{#345675}