Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issue 131473011: Clean the SVGSVGElement interface IDL (Closed)

Created:
6 years, 10 months ago by fs
Modified:
6 years, 10 months ago
CC:
blink-reviews, krit, arv+blink, watchdog-blink-watchlist_google.com, ed+blinkwatch_opera.com, f(malita), gyuyoung.kim_webkit.org, Inactive, Stephen Chennney, pdr.
Visibility:
Public.

Description

Clean the SVGSVGElement interface IDL Remove some weird looking uses of [Default=Undefined] on suspendRedraw, unsuspendRedraw and getElementById. This means that TypeErrors will be thrown for the 0 arguments case. This is consistent with Gecko. Since the *Redraw* methods are deprecated (except forceRedraw), remove the comment about (WebKit) bug# (11275, dupe of 10408) and move the implementation stubs to the header file. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167078

Patch Set 1 #

Patch Set 2 : Drop argument names. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -28 lines) Patch
M Source/core/svg/SVGSVGElement.h View 1 1 chunk +5 lines, -4 lines 0 comments Download
M Source/core/svg/SVGSVGElement.cpp View 1 chunk +0 lines, -21 lines 0 comments Download
M Source/core/svg/SVGSVGElement.idl View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
fs
6 years, 10 months ago (2014-02-12 17:19:04 UTC) #1
rwlbuis
On 2014/02/12 17:19:04, fs wrote: Looks good to me (but I am not an Owner).
6 years, 10 months ago (2014-02-12 18:02:15 UTC) #2
Stephen Chennney
Bad baselines, but LGTM in the email, except ... Please fix: In the method declarations ...
6 years, 10 months ago (2014-02-12 18:14:22 UTC) #3
fs
On 2014/02/12 18:14:22, Stephen Chenney wrote: > Bad baselines, ... *sigh* > Please fix: In ...
6 years, 10 months ago (2014-02-13 09:22:25 UTC) #4
fs
The CQ bit was checked by fs@opera.com
6 years, 10 months ago (2014-02-13 09:22:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/131473011/100001
6 years, 10 months ago (2014-02-13 09:22:50 UTC) #6
commit-bot: I haz the power
6 years, 10 months ago (2014-02-13 11:38:17 UTC) #7
Message was sent while issue was closed.
Change committed as 167078

Powered by Google App Engine
This is Rietveld 408576698