Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Unified Diff: trunk/src/ppapi/cpp/file_ref.h

Issue 131473002: Revert 243802 "PPAPI: Add new PPB_FileRef.MakeDirectory to suppo..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « trunk/src/ppapi/c/ppb_file_ref.h ('k') | trunk/src/ppapi/cpp/file_ref.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/ppapi/cpp/file_ref.h
===================================================================
--- trunk/src/ppapi/cpp/file_ref.h (revision 243841)
+++ trunk/src/ppapi/cpp/file_ref.h (working copy)
@@ -90,21 +90,31 @@
/// <code>PP_FileSystemType_External</code>.
FileRef GetParent() const;
- /// MakeDirectory() makes a new directory in the file system according to the
- /// given <code>make_directory_flags</code>, which is a bit-mask of the
- /// <code>PP_MakeDirectoryFlags</code> values. It is not valid to make a
- /// directory in the external file system.
+ /// MakeDirectory() makes a new directory in the file system. It is not
+ /// valid to make a directory in the external file system.
+ /// <strong>Note:</strong> Use MakeDirectoryIncludingAncestors() to create
+ /// parent directories.
///
- /// @param[in] make_directory_flags A bit-mask of the
- /// <code>PP_MakeDirectoryFlags</code> values.
- /// See <code>ppb_file_ref.h</code> for more details.
/// @param[in] cc A <code>CompletionCallback</code> to be called upon
/// completion of MakeDirectory().
///
/// @return An int32_t containing an error code from <code>pp_errors.h</code>.
- int32_t MakeDirectory(int32_t make_directory_flags,
- const CompletionCallback& cc);
+ /// Succeeds if the directory already exists. Fails if ancestor
+ /// directortories do not exist (see MakeDirectoryIncludingAncestors for the
+ /// alternative).
+ int32_t MakeDirectory(const CompletionCallback& cc);
+ /// MakeDirectoryIncludingAncestors() makes a new directory in the file
+ /// system as well as any parent directories. It is not valid to make a
+ /// directory in the external file system.
+ ///
+ /// @param[in] cc A <code>CompletionCallback</code> to be called upon
+ /// completion of MakeDirectoryIncludingAncestors().
+ ///
+ /// @return An int32_t containing an error code from <code>pp_errors.h</code>.
+ /// Succeeds if the directory already exists.
+ int32_t MakeDirectoryIncludingAncestors(const CompletionCallback& cc);
+
/// Touch() Updates time stamps for a file. You must have write access to the
/// file if it exists in the external filesystem.
///
« no previous file with comments | « trunk/src/ppapi/c/ppb_file_ref.h ('k') | trunk/src/ppapi/cpp/file_ref.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698