Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1341)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 131473002: Revert 243802 "PPAPI: Add new PPB_FileRef.MakeDirectory to suppo..." (Closed)

Created:
6 years, 11 months ago by nhiroki
Modified:
6 years, 11 months ago
Reviewers:
nhiroki
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 243802 "PPAPI: Add new PPB_FileRef.MakeDirectory to suppo..." This breaks examples of NaCl SDK. http://build.chromium.org/p/client.nacl.sdk/builders/mac-sdk-multi/builds/6796 > PPAPI: Add new PPB_FileRef.MakeDirectory to support exclusive operation > > Current PPB_FileRef.MakeDirectory returns PP_OK if a directory exists on > the given path. This makes it difficult to create POSIX compatible API on > top of PPAPI. > > This change introduces new PPB_FileRef.MakeDirectory as dev channel API. > That makes a new directory according to the given PP_MakeDirectoryFlags > values. The flags provide exclusive operation option. If exclusive flag > is specified and a directory exists on the given path, the function fails > and returns PP_ERROR_FILEEXISTS. > > > BUG=314879 > TEST=browser_tests > > Review URL: https://codereview.chromium.org/113363004 TBR=nhiroki@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243842

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -380 lines) Patch
M trunk/src/chrome/browser/component_updater/ppapi_utils.cc View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/content/browser/renderer_host/pepper/pepper_external_file_ref_backend.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/content/browser/renderer_host/pepper/pepper_external_file_ref_backend.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/content/browser/renderer_host/pepper/pepper_file_ref_host.h View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/content/browser/renderer_host/pepper/pepper_file_ref_host.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M trunk/src/content/browser/renderer_host/pepper/pepper_internal_file_ref_backend.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/content/browser/renderer_host/pepper/pepper_internal_file_ref_backend.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M trunk/src/content/renderer/pepper/plugin_module.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M trunk/src/ppapi/api/ppb_file_ref.idl View 2 chunks +1 line, -42 lines 0 comments Download
M trunk/src/ppapi/c/ppb_file_ref.h View 7 chunks +15 lines, -63 lines 0 comments Download
M trunk/src/ppapi/cpp/file_ref.h View 1 chunk +19 lines, -9 lines 0 comments Download
M trunk/src/ppapi/cpp/file_ref.cc View 12 chunks +26 lines, -65 lines 0 comments Download
M trunk/src/ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_shim.c View 5 chunks +0 lines, -87 lines 0 comments Download
M trunk/src/ppapi/proxy/file_ref_resource.h View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/ppapi/proxy/file_ref_resource.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/ppapi/proxy/interface_list.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M trunk/src/ppapi/proxy/ppapi_messages.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/ppapi/tests/test_file_io.cc View 1 chunk +1 line, -2 lines 0 comments Download
M trunk/src/ppapi/tests/test_file_ref.cc View 8 chunks +26 lines, -51 lines 0 comments Download
M trunk/src/ppapi/thunk/interfaces_ppb_public_dev_channel.h View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/ppapi/thunk/ppb_file_ref_api.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/ppapi/thunk/ppb_file_ref_thunk.cc View 3 chunks +2 lines, -34 lines 0 comments Download
M trunk/src/ppapi/thunk/thunk.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
nhiroki
6 years, 11 months ago (2014-01-09 11:08:40 UTC) #1
nhiroki
6 years, 11 months ago (2014-01-09 11:09:23 UTC) #2
Message was sent while issue was closed. 
Committed patchset #1 manually as r243842.

Powered by Google App Engine
This is Rietveld 408576698