Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 13147004: NOT FOR COMMIT: Revive the old virtual keyboard extension. (Closed)

Created:
7 years, 9 months ago by bryeung
Modified:
7 years, 8 months ago
Reviewers:
CC:
chromium-reviews, Aaron Boodman, arv+watch_chromium.org, chromium-apps-reviews_chromium.org, rjkroege, sadrul
Visibility:
Public.

Description

Revive the old virtual keyboard extension. This is the code that was removed about 2 years ago. BUG=none

Patch Set 1 #

Patch Set 2 : format nits #

Patch Set 3 : more nits #

Patch Set 4 : Remove accidentally included kChromeUIKeyboardHost #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1519 lines, -2 lines) Patch
M chrome/browser/browser_resources.grd View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/component_loader.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/component_loader.cc View 1 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/resources/component_extension_resources.grd View 1 2 chunks +22 lines, -2 lines 0 comments Download
A chrome/browser/resources/virtual_keyboard/common.js View 1 1 chunk +716 lines, -0 lines 0 comments Download
A chrome/browser/resources/virtual_keyboard/images/chevron.svg View 1 chunk +9 lines, -0 lines 0 comments Download
A chrome/browser/resources/virtual_keyboard/images/del.svg View 1 chunk +17 lines, -0 lines 0 comments Download
A chrome/browser/resources/virtual_keyboard/images/keyboard.svg View 1 chunk +25 lines, -0 lines 0 comments Download
A chrome/browser/resources/virtual_keyboard/images/mic.svg View 1 chunk +23 lines, -0 lines 0 comments Download
A chrome/browser/resources/virtual_keyboard/images/ret.svg View 1 chunk +17 lines, -0 lines 0 comments Download
A chrome/browser/resources/virtual_keyboard/images/shift.svg View 1 chunk +15 lines, -0 lines 0 comments Download
A chrome/browser/resources/virtual_keyboard/images/shift-down.svg View 1 chunk +15 lines, -0 lines 0 comments Download
A chrome/browser/resources/virtual_keyboard/images/tab.svg View 1 chunk +14 lines, -0 lines 0 comments Download
A chrome/browser/resources/virtual_keyboard/index.html View 2 1 chunk +17 lines, -0 lines 0 comments Download
A chrome/browser/resources/virtual_keyboard/layout_us.js View 1 1 chunk +89 lines, -0 lines 0 comments Download
A chrome/browser/resources/virtual_keyboard/main.css View 1 1 chunk +204 lines, -0 lines 0 comments Download
A chrome/browser/resources/virtual_keyboard/main.js View 1 2 1 chunk +192 lines, -0 lines 0 comments Download
A chrome/browser/resources/virtual_keyboard/manifest.json View 1 chunk +14 lines, -0 lines 0 comments Download
A chrome/browser/resources/virtual_keyboard/touches.js View 1 1 chunk +120 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
bryeung
Before commit, this still needs: - proper hiding behind a flag - JS/CSS style clean-up ...
7 years, 9 months ago (2013-03-28 14:37:26 UTC) #1
bshe
patchset 2 and 3 should address all format issues. Also, it seems the keyboard override_url ...
7 years, 9 months ago (2013-03-28 20:12:23 UTC) #2
bryeung
7 years, 9 months ago (2013-03-28 20:13:20 UTC) #3
Awesome!

The proper setup as webui is in another CL.

On Thu, Mar 28, 2013 at 4:12 PM,  <bshe@chromium.org> wrote:
> patchset 2 and 3 should address all format issues.
> Also, it seems the keyboard override_url is missing and I can't open the
> extension by go to chrome://keyboard:
>
https://code.google.com/p/chromium/codesearch/#chromium/src/chrome/common/ext...
> Not sure if it is intented thought.
>
>
> On 2013/03/28 14:37:26, bryeung wrote:
>>
>> Before commit, this still needs:
>> - proper hiding behind a flag
>> - JS/CSS style clean-up (apparently we've introduced a bunch of style
>> checking
>> that this old code now violates)
>
>
>
> https://codereview.chromium.org/13147004/

Powered by Google App Engine
This is Rietveld 408576698