Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Issue 1314673010: MIPS: Fix 'Optimize simulator.' (Closed)

Created:
5 years, 3 months ago by balazs.kilvady
Modified:
5 years, 3 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: Fix 'Optimize simulator.' For simulator optimization we modified Instruction::InstructionType() function so a simpler but less complete InstructionType() function used by default. This fix enables the full InstructionType checking to properly decode a dd-constant label as unsupported opcode, rather than aborting. BUG=chromium:528875 LOG=NO Committed: https://crrev.com/affd6dfcb5676347025dd8c8899e15fae1c56d53 Cr-Commit-Position: refs/heads/master@{#30644}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/mips/disasm-mips.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
balazs.kilvady
5 years, 3 months ago (2015-09-08 18:21:47 UTC) #2
paul.l...
LGTM. But please add the bug number to the issue, so it gets tracked properly.
5 years, 3 months ago (2015-09-08 18:25:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1314673010/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1314673010/1
5 years, 3 months ago (2015-09-08 19:02:41 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-08 19:32:11 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-08 19:32:34 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/affd6dfcb5676347025dd8c8899e15fae1c56d53
Cr-Commit-Position: refs/heads/master@{#30644}

Powered by Google App Engine
This is Rietveld 408576698