Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(691)

Unified Diff: runtime/vm/log_test.cc

Issue 1314673008: Migrate logging infrastructure Isolate->Thread (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Fix test. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/log.cc ('k') | runtime/vm/object.cc » ('j') | runtime/vm/thread.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/log_test.cc
diff --git a/runtime/vm/log_test.cc b/runtime/vm/log_test.cc
index 370fefc2f81cef9b3fde8c28324214c2dab3ffdd..84ef8559a829b3b9958c7f0daee997bfddd8708b 100644
--- a/runtime/vm/log_test.cc
+++ b/runtime/vm/log_test.cc
@@ -47,13 +47,12 @@ class LogTestHelper : public AllStatic {
TEST_CASE(Log_Macro) {
test_output_ = NULL;
- Isolate* isolate = Isolate::Current();
- Log* log = isolate->Log();
+ Log* log = Log::Current();
LogTestHelper::SetPrinter(log, TestPrinter);
- ISL_Print("Hello %s", "World");
+ THR_Print("Hello %s", "World");
EXPECT_STREQ("Hello World", test_output_);
- ISL_Print("SingleArgument");
+ THR_Print("SingleArgument");
EXPECT_STREQ("SingleArgument", test_output_);
}
@@ -72,15 +71,13 @@ TEST_CASE(Log_Block) {
test_output_ = NULL;
Log* log = new Log(TestPrinter);
- Isolate* isolate = Isolate::Current();
-
EXPECT_EQ(reinterpret_cast<const char*>(NULL), test_output_);
{
- LogBlock ba(isolate, log);
+ LogBlock ba(thread, log);
log->Print("APPLE");
EXPECT_EQ(reinterpret_cast<const char*>(NULL), test_output_);
{
- LogBlock ba(isolate, log);
+ LogBlock ba(thread, log);
log->Print("BANANA");
EXPECT_EQ(reinterpret_cast<const char*>(NULL), test_output_);
}
« no previous file with comments | « runtime/vm/log.cc ('k') | runtime/vm/object.cc » ('j') | runtime/vm/thread.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698