Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Unified Diff: runtime/vm/gc_marker.cc

Issue 1314673008: Migrate logging infrastructure Isolate->Thread (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Fix test. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/gc_marker.cc
diff --git a/runtime/vm/gc_marker.cc b/runtime/vm/gc_marker.cc
index 42a08bd6e7c3126aecd2abf7f66b4fe04f20b30e..1d151d03c4e6298710b59c8366f223a2a5bee4fc 100644
--- a/runtime/vm/gc_marker.cc
+++ b/runtime/vm/gc_marker.cc
@@ -110,7 +110,7 @@ class SkippedCodeFunctions : public ZoneAllocated {
// helper functions to the raw object interface.
String name;
name = func->ptr()->name_;
- ISL_Print("Detaching code: %s\n", name.ToCString());
+ THR_Print("Detaching code: %s\n", name.ToCString());
current_code_count++;
}
}
@@ -127,8 +127,8 @@ class SkippedCodeFunctions : public ZoneAllocated {
}
}
if (FLAG_log_code_drop) {
- ISL_Print(" total detached current: %" Pd "\n", current_code_count);
- ISL_Print(" total detached unoptimized: %" Pd "\n",
+ THR_Print(" total detached current: %" Pd "\n", current_code_count);
+ THR_Print(" total detached unoptimized: %" Pd "\n",
unoptimized_code_count);
}
// Clean up.
@@ -700,11 +700,9 @@ void GCMarker::MarkObjects(Isolate* isolate,
MarkingWeakVisitor mark_weak;
IterateWeakRoots(isolate, &mark_weak,
!visit_prologue_weak_persistent_handles);
- // TODO(koda): Move this into Phase 3 after making ISL_Print thread-safe
- // (used in SkippedCodeFunctions::DetachCode).
- FinalizeResultsFrom(&mark);
MainSync(num_tasks);
// Phase 3: Finalize results from all markers (detach code, etc.).
+ FinalizeResultsFrom(&mark);
MainSync(num_tasks);
// Finalization complete and all tasks exited.
}

Powered by Google App Engine
This is Rietveld 408576698