Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1314663002: Remove inclusion of RetainPtr.h in SimpleFontData.h (Closed)

Created:
5 years, 4 months ago by jbroman
Modified:
5 years, 3 months ago
Reviewers:
drott
CC:
blink-reviews, Rik, danakj, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), Justin Novosad, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove inclusion of RetainPtr.h in SimpleFontData.h This file does not use RetainPtr; move the include to FontPlatformDataMac.mm, which does need it. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201646

Patch Set 1 #

Patch Set 2 : Add wtf/RetainPtr.h to FontPlatformDataMac.mm, and sort includes #

Patch Set 3 : unsort unrelated includes #

Patch Set 4 : use #import instead of #include for local consistency #

Patch Set 5 : add now-needed include to ScrollbarThemeMacOverlayAPI.mm #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -8 lines) Patch
M Source/platform/fonts/SimpleFontData.h View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/platform/fonts/mac/FontPlatformDataMac.mm View 1 2 3 1 chunk +4 lines, -4 lines 0 comments Download
M Source/platform/scroll/ScrollbarThemeMacOverlayAPI.mm View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
jbroman
Trivial cleanup? Saw this while hunting for "#if OS(...)" guards that aren't needed.
5 years, 4 months ago (2015-08-25 15:09:30 UTC) #2
jbroman
On 2015/08/25 at 15:09:30, jbroman wrote: > Trivial cleanup? Saw this while hunting for "#if ...
5 years, 3 months ago (2015-08-29 20:39:13 UTC) #3
drott
LGTM
5 years, 3 months ago (2015-08-31 09:06:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1314663002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1314663002/60001
5 years, 3 months ago (2015-08-31 13:29:53 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/106664)
5 years, 3 months ago (2015-08-31 13:51:13 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1314663002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1314663002/80001
5 years, 3 months ago (2015-09-02 13:53:57 UTC) #11
commit-bot: I haz the power
5 years, 3 months ago (2015-09-02 14:35:08 UTC) #12
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201646

Powered by Google App Engine
This is Rietveld 408576698